Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2176173003: [Turbofan] Revert FP register aliasing support on Arm. (Closed)

Created:
4 years, 5 months ago by bbudge
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, danno, georgia.kouveli
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Revert FP register aliasing support on Arm. - Changes register allocation to only use even numbered registers on Arm. - Turns on float32 testing in test-gap-resolver.cc. This is effectively a revert of: https://codereview.chromium.org/2086653003/ LOG=N BUG=V8:4124, V8:5202 Committed: https://crrev.com/55b01ccbfc2b80b988ce9cb46b6368d8b4f13039 Cr-Commit-Position: refs/heads/master@{#38151}

Patch Set 1 #

Patch Set 2 : Fix non-Arm RegisterConfiguration, fix Arm box2d. #

Patch Set 3 : Remove stray debug code, restore Bitcast changes. #

Patch Set 4 : Fix RegisterAllocatorTest (unittests). #

Patch Set 5 : Clean up. #

Patch Set 6 : Back out float register slots for Arm. #

Total comments: 2

Patch Set 7 : Review comment. #

Patch Set 8 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -405 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 3 4 5 6 7 16 chunks +56 lines, -99 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +2 lines, -8 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 3 4 1 chunk +1 line, -8 lines 0 comments Download
M src/compiler/move-optimizer.cc View 1 chunk +12 lines, -40 lines 0 comments Download
M src/compiler/register-allocator.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 5 6 18 chunks +34 lines, -198 lines 0 comments Download
M src/compiler/wasm-linkage.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/register-configuration.h View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M src/register-configuration.cc View 1 2 3 4 chunks +12 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/register-configuration-unittest.cc View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 36 (30 generated)
bbudge
I attempted to back out just the support for odd-numbered single VFP registers.
4 years, 5 months ago (2016-07-25 21:00:09 UTC) #16
Mircea Trofin
lgtm https://codereview.chromium.org/2176173003/diff/100001/src/compiler/register-allocator.cc File src/compiler/register-allocator.cc (right): https://codereview.chromium.org/2176173003/diff/100001/src/compiler/register-allocator.cc#newcode79 src/compiler/register-allocator.cc:79: return 8; isn't there a constant we could ...
4 years, 4 months ago (2016-07-27 23:29:31 UTC) #24
bbudge
https://codereview.chromium.org/2176173003/diff/100001/src/compiler/register-allocator.cc File src/compiler/register-allocator.cc (right): https://codereview.chromium.org/2176173003/diff/100001/src/compiler/register-allocator.cc#newcode79 src/compiler/register-allocator.cc:79: return 8; On 2016/07/27 23:29:31, Mircea Trofin wrote: > ...
4 years, 4 months ago (2016-07-29 00:45:39 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176173003/140001
4 years, 4 months ago (2016-07-29 00:46:02 UTC) #32
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 4 months ago (2016-07-29 00:47:51 UTC) #34
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 00:51:09 UTC) #36
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/55b01ccbfc2b80b988ce9cb46b6368d8b4f13039
Cr-Commit-Position: refs/heads/master@{#38151}

Powered by Google App Engine
This is Rietveld 408576698