Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: src/compiler/wasm-linkage.cc

Issue 2176173003: [Turbofan] Revert FP register aliasing support on Arm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/register-allocator.cc ('k') | src/register-configuration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/wasm-linkage.cc
diff --git a/src/compiler/wasm-linkage.cc b/src/compiler/wasm-linkage.cc
index ee2ae10fcded8fbc309861c230228e2c7f768bfc..6537219cc074cdfcb5fb7c1eb7c6e039c2331fcf 100644
--- a/src/compiler/wasm-linkage.cc
+++ b/src/compiler/wasm-linkage.cc
@@ -177,17 +177,6 @@ struct Allocator {
// Allocate a floating point register/stack location.
if (fp_offset < fp_count) {
DoubleRegister reg = fp_regs[fp_offset++];
-#if V8_TARGET_ARCH_ARM
- // Allocate floats using a double register, but modify the code to
- // reflect how ARM FP registers alias.
- // TODO(bbudge) Modify wasm linkage to allow use of all float regs.
- if (type == kAstF32) {
- int float_reg_code = reg.code() * 2;
- DCHECK(float_reg_code < RegisterConfiguration::kMaxFPRegisters);
- return regloc(DoubleRegister::from_code(float_reg_code),
- MachineTypeFor(type));
- }
-#endif
return regloc(reg, MachineTypeFor(type));
} else {
int offset = -1 - stack_offset;
« no previous file with comments | « src/compiler/register-allocator.cc ('k') | src/register-configuration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698