Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: src/compiler/instruction.h

Issue 2176173003: [Turbofan] Revert FP register aliasing support on Arm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | src/compiler/instruction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction.h
diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h
index 05c0fb6e0777b96d269ef384e856ce0fce789d86..584fca18b11e79fc70a31d9daff75b07aa1d7c46 100644
--- a/src/compiler/instruction.h
+++ b/src/compiler/instruction.h
@@ -607,14 +607,8 @@ uint64_t InstructionOperand::GetCanonicalizedValue() const {
if (IsAllocated() || IsExplicit()) {
MachineRepresentation canonical = MachineRepresentation::kNone;
if (IsFPRegister()) {
- if (kSimpleFPAliasing) {
- // We treat all FP register operands the same for simple aliasing.
- canonical = MachineRepresentation::kFloat64;
- } else {
- // We need to distinguish FP register operands of different reps when
- // aliasing is not simple (e.g. ARM).
- canonical = LocationOperand::cast(this)->representation();
- }
+ // We treat all FP register operands the same for simple aliasing.
+ canonical = MachineRepresentation::kFloat64;
}
return InstructionOperand::KindField::update(
LocationOperand::RepresentationField::update(this->value_, canonical),
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | src/compiler/instruction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698