Add "Failed" custom element state

Add "Failed" custom element state

To avoid constructor running multiple times on the same element[1],
a new "failed" custom element state[2] was added to the spec.

This patch:
1. Adds the CustomElementState::Failed.
2. Simplifies getCustomElementState().
3. Removes Element::isCustomElement() to match code conventions to the
   spec terminologies.

[1] https://github.com/w3c/webcomponents/issues/533
[2] https://dom.spec.whatwg.org/#concept-element-custom-element-state

BUG=594918
Committed: https://crrev.com/5ac03d7943472ea900610fdb5cb27263fe8605c4
Cr-Commit-Position: refs/heads/master@{#407754}

[kojii, 2016-07-22 09:35:05]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 09:35:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-22 10:07:28]

Description was changed from

==========
state-failed

BUG=
==========

to

==========
Add "Failed" custom element state

To avoid constructor running multiple times on the same element[1],
a new "failed" custom element state[2] was added to the spec.

This patch:
1. Added the CustomElementState::Failed.
2. Simplified getCustomElementState().
3. Removed Element::isCustomElement() to match code conventions to the
   spec terminologies.

[1] https://github.com/w3c/webcomponents/issues/533
[2] https://dom.spec.whatwg.org/#concept-element-custom-element-state

BUG=594918
==========

[kojii, 2016-07-22 10:08:04]

Description was changed from

==========
Add "Failed" custom element state

To avoid constructor running multiple times on the same element[1],
a new "failed" custom element state[2] was added to the spec.

This patch:
1. Added the CustomElementState::Failed.
2. Simplified getCustomElementState().
3. Removed Element::isCustomElement() to match code conventions to the
   spec terminologies.

[1] https://github.com/w3c/webcomponents/issues/533
[2] https://dom.spec.whatwg.org/#concept-element-custom-element-state

BUG=594918
==========

to

==========
Add "Failed" custom element state

To avoid constructor running multiple times on the same element[1],
a new "failed" custom element state[2] was added to the spec.

This patch:
1. Adds the CustomElementState::Failed.
2. Simplifies getCustomElementState().
3. Removes Element::isCustomElement() to match code conventions to the
   spec terminologies.

[1] https://github.com/w3c/webcomponents/issues/533
[2] https://dom.spec.whatwg.org/#concept-element-custom-element-state

BUG=594918
==========

[commit-bot: I haz the power, 2016-07-22 10:57:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 10:57:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2016-07-22 11:18:03]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 11:18:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 12:24:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 12:24:32]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-07-23 02:44:20]

kojii@chromium.org changed reviewers:
+ dominicc@chromium.org

[kojii, 2016-07-23 02:44:20]

PTAL.

[dominicc (has gone to gerrit), 2016-07-26 05:47:43]

Comments inline.

https://codereview.chromium.org/2173623003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js
(right):

https://codereview.chromium.org/2173623003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js:15:
function test_with_window(f, name, srcdoc) {
Looks like this got mixed into this patch; it does not seem to be used.

https://codereview.chromium.org/2173623003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2173623003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.cpp:1920: return
CustomElement::isDefined(getCustomElementState());
Do we need CustomElement::isDefined and Element::isDefined? Is there any place
where we're *just* testing a state and not an element's state?

https://codereview.chromium.org/2173623003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.h (right):

https://codereview.chromium.org/2173623003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.h:377: bool isDefined() const;
Maybe we want to keep inlining this?

https://codereview.chromium.org/2173623003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/2173623003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Node.cpp:2355: bool isDefinedChanged = false;
It might be better to have something that tests "is defined" and just do

bool wasDefined = ...;

// complicated code

if (... != wasDefined) {
  // change handling
}

That is shorter and probably clearer.

https://codereview.chromium.org/2173623003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Node.h (right):

https://codereview.chromium.org/2173623003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Node.h:706: CustomElementStateMask = 1 <<
nodeCustomElementShift | 1 << (nodeCustomElementShift + 1),
Maybe 0x3 << nodeCustomElementShift is simpler to read?

[kojii, 2016-07-26 06:23:43]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 06:23:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-26 06:27:19]

All done. Turned out that operator<< for LOG is no longer necessary thanks to
LOG supporting enum class, so removed.

[dominicc (has gone to gerrit), 2016-07-26 06:55:31]

LGTM

I see that you were using the srcdoc, sorry about that.

Might be nice to only call toElement once, but up to you.

[kojii, 2016-07-26 07:02:12]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 07:02:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-26 07:04:47]

kojii@chromium.org changed reviewers:
+ haraken@chromium.org

[kojii, 2016-07-26 07:04:48]

haraken@, PTAL for bindings; moved non-v8-specific logic to dom/.

Thank you dominicc@, multiple toElement() fixed.

[Yuki, 2016-07-26 07:15:27]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2016-07-26 07:15:28]

LGTM for bindings.

[kojii, 2016-07-26 07:55:44]

Thank you!

[kojii, 2016-07-26 07:56:09]

The CQ bit was unchecked by kojii@chromium.org

[kojii, 2016-07-26 07:56:16]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-07-26 07:56:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2173623003/#ps80001
(title: "Avoid multiple toElement")

[commit-bot: I haz the power, 2016-07-26 07:56:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-07-26 08:09:50]

bindings/ LGTM

[commit-bot: I haz the power, 2016-07-26 09:53:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-26 09:55:49]

Description was changed from

==========
Add "Failed" custom element state

To avoid constructor running multiple times on the same element[1],
a new "failed" custom element state[2] was added to the spec.

This patch:
1. Adds the CustomElementState::Failed.
2. Simplifies getCustomElementState().
3. Removes Element::isCustomElement() to match code conventions to the
   spec terminologies.

[1] https://github.com/w3c/webcomponents/issues/533
[2] https://dom.spec.whatwg.org/#concept-element-custom-element-state

BUG=594918
==========

to

==========
Add "Failed" custom element state

To avoid constructor running multiple times on the same element[1],
a new "failed" custom element state[2] was added to the spec.

This patch:
1. Adds the CustomElementState::Failed.
2. Simplifies getCustomElementState().
3. Removes Element::isCustomElement() to match code conventions to the
   spec terminologies.

[1] https://github.com/w3c/webcomponents/issues/533
[2] https://dom.spec.whatwg.org/#concept-element-custom-element-state

BUG=594918

Committed: https://crrev.com/5ac03d7943472ea900610fdb5cb27263fe8605c4
Cr-Commit-Position: refs/heads/master@{#407754}
==========

[commit-bot: I haz the power, 2016-07-26 09:55:50]

Patchset 5 (id:??) landed as
https://crrev.com/5ac03d7943472ea900610fdb5cb27263fe8605c4
Cr-Commit-Position: refs/heads/master@{#407754}