third_party/WebKit/Source/core/dom/Element.cpp - Issue 2173623003: Add "Failed" custom element state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2173623003: Add "Failed" custom element state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avoid multiple toElement Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 5334335ce4bd85fc5ec74ef610f142f5836b8d4c..4257023239a20922beb53cf9cd42dab254c8ae34 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -1959,7 +1959,7 @@ ShadowRoot* Element::attachShadow(const ScriptState* scriptState, const ShadowRo

const AtomicString& tagName = localName();

bool tagNameIsSupported = isV0CustomElement()

- || isCustomElement()

+ || getCustomElementState() != CustomElementState::Uncustomized

|| tagName == HTMLNames::articleTag

|| tagName == HTMLNames::asideTag

|| tagName == HTMLNames::blockquoteTag