Add "Failed" custom element state

third_party/WebKit/Source/core/dom/Node.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 73 matching lines @@
 class SVGQualifiedName;
 class ShadowRoot;
 template <typename NodeType> class StaticNodeTypeList;
 using StaticNodeList = StaticNodeTypeList<Node>;
 class StyleChangeReasonForTracing;
 class TagCollection;
 class Text;
 class TouchEvent;
 
 const int nodeStyleChangeShift = 19;
+const int nodeCustomElementShift = 21;
 
 enum StyleChangeType {
     NoStyleChange = 0,
     LocalStyleChange = 1 << nodeStyleChangeShift,
     SubtreeStyleChange = 2 << nodeStyleChangeShift,
     NeedsReattachStyleChange = 3 << nodeStyleChangeShift,
 };
 
 enum class CustomElementState {
+    // https://dom.spec.whatwg.org/#concept-element-custom-element-state
     Uncustomized = 0,
-    Custom = 1,
-    Undefined = 2,
+    Custom = 1 << nodeCustomElementShift,
+    Undefined = 2 << nodeCustomElementShift,
+    Failed = 3 << nodeCustomElementShift,
+
+    NotDefinedFlag = 2 << nodeCustomElementShift,
 };
 
 CORE_EXPORT std::ostream& operator<<(std::ostream&, CustomElementState);
 
 class NodeRareDataBase {
 public:
     LayoutObject* layoutObject() const { return m_layoutObject; }
     void setLayoutObject(LayoutObject* layoutObject) { m_layoutObject = layoutObject; }
 
 protected:
@@ skipping 130 matching lines @@
     bool isTextNode() const { return getFlag(IsTextFlag); }
     bool isHTMLElement() const { return getFlag(IsHTMLFlag); }
     bool isSVGElement() const { return getFlag(IsSVGFlag); }
 
     bool isPseudoElement() const { return getPseudoId() != PseudoIdNone; }
     bool isBeforePseudoElement() const { return getPseudoId() == PseudoIdBefore; }
     bool isAfterPseudoElement() const { return getPseudoId() == PseudoIdAfter; }
     bool isFirstLetterPseudoElement() const { return getPseudoId() == PseudoIdFirstLetter; }
     virtual PseudoId getPseudoId() const { return PseudoIdNone; }
 
-    bool isCustomElement() const { return getFlag(CustomElementFlag); }
-    CustomElementState getCustomElementState() const;
+    CustomElementState getCustomElementState() const { return static_cast<CustomElementState>(m_nodeFlags & CustomElementStateMask); }
     void setCustomElementState(CustomElementState);
     bool isV0CustomElement() const { return getFlag(V0CustomElementFlag); }
     enum V0CustomElementState {
         V0NotCustomElement  = 0,
         V0WaitingForUpgrade = 1 << 0,
         V0Upgraded          = 1 << 1
     };
     V0CustomElementState getV0CustomElementState() const
     {
         return isV0CustomElement()
@@ skipping 424 matching lines @@
 
         // Flags related to recalcStyle.
         SVGFilterNeedsLayerUpdateFlag = 1 << 13,
         HasCustomStyleCallbacksFlag = 1 << 14,
         ChildNeedsStyleInvalidationFlag = 1 << 15,
         NeedsStyleInvalidationFlag = 1 << 16,
         ChildNeedsDistributionRecalcFlag = 1 << 17,
         ChildNeedsStyleRecalcFlag = 1 << 18,
         StyleChangeMask = 1 << nodeStyleChangeShift | 1 << (nodeStyleChangeShift + 1),
 
-        CustomElementFlag = 1 << 21,
-        CustomElementCustomFlag = 1 << 22,
+        CustomElementStateMask = 1 << nodeCustomElementShift | 1 << (nodeCustomElementShift + 1),

[dominicc (has gone to gerrit), 2016/07/26 05:47:42]

Maybe 0x3 << nodeCustomElementShift is simpler to read?

 
         HasNameOrIsEditingTextFlag = 1 << 23,
         HasWeakReferencesFlag = 1 << 24,
         V8CollectableDuringMinorGCFlag = 1 << 25,
         HasEventTargetDataFlag = 1 << 26,
         AlreadySpellCheckedFlag = 1 << 27,
 
         V0CustomElementFlag = 1 << 28,
         V0CustomElementUpgradedFlag = 1 << 29,
 
@@ skipping 178 matching lines @@
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showNode(const blink::Node*);
 void showTree(const blink::Node*);
 void showNodePath(const blink::Node*);
 #endif
 
 #endif // Node_h