Add "Failed" custom element state

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 37 matching lines @@
 #include "core/dom/NodeRareData.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/dom/ProcessingInstruction.h"
 #include "core/dom/Range.h"
 #include "core/dom/StaticNodeList.h"
 #include "core/dom/StyleEngine.h"
 #include "core/dom/TemplateContentDocumentFragment.h"
 #include "core/dom/Text.h"
 #include "core/dom/TreeScopeAdopter.h"
 #include "core/dom/UserActionElementSet.h"
+#include "core/dom/custom/CustomElement.h"
 #include "core/dom/shadow/ElementShadow.h"
 #include "core/dom/shadow/FlatTreeTraversal.h"
 #include "core/dom/shadow/InsertionPoint.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/dom/shadow/SlotAssignment.h"
 #include "core/editing/EditingUtilities.h"
 #include "core/editing/markers/DocumentMarkerController.h"
 #include "core/events/Event.h"
 #include "core/events/EventDispatchMediator.h"
 #include "core/events/EventDispatcher.h"
@@ skipping 2266 matching lines @@
     DCHECK(isUserActionElement());
     return document().userActionElements().isFocused(this);
 }
 
 std::ostream& operator<<(std::ostream& os, CustomElementState state)
 {
     switch (state) {
     case CustomElementState::Uncustomized: return os << "Uncustomized";
     case CustomElementState::Undefined: return os << "Undefined";
     case CustomElementState::Custom: return os << "Custom";
+    case CustomElementState::Failed: return os << "Failed";
     default: NOTREACHED();
     }
     return os;
 }
 
-CustomElementState Node::getCustomElementState() const
-{
-    return !isCustomElement()
-        ? CustomElementState::Uncustomized
-        : (getFlag(CustomElementCustomFlag) ? CustomElementState::Custom : CustomElementState::Undefined);
-}
-
 void Node::setCustomElementState(CustomElementState newState)
 {
     CustomElementState oldState = getCustomElementState();
 
+    bool isDefinedChanged = false;

[dominicc (has gone to gerrit), 2016/07/26 05:47:42]

It might be better to have something that tests "is defined" and just do

bool wasDefined = ...;

// complicated code

if (... != wasDefined) {
  // change handling
}

That is shorter and probably clearer.

     switch (newState) {
     case CustomElementState::Uncustomized:
         NOTREACHED(); // Everything starts in this state
         return;
 
     case CustomElementState::Undefined:
         DCHECK_EQ(CustomElementState::Uncustomized, oldState);
+        isDefinedChanged = true;
         break;
 
     case CustomElementState::Custom:
         DCHECK_EQ(CustomElementState::Undefined, oldState);
+        isDefinedChanged = true;
+        break;
+
+    case CustomElementState::Failed:
+        DCHECK_NE(CustomElementState::Failed, oldState);
+        isDefinedChanged = CustomElement::isDefined(oldState);
         break;
     }
 
     DCHECK(isHTMLElement());
     DCHECK_NE(V0Upgraded, getV0CustomElementState());
 #if DCHECK_IS_ON()
     bool wasDefined = toElement(this)->isDefined();
 #endif
 
-    setFlag(CustomElementFlag);
-    if (newState == CustomElementState::Custom)
-        setFlag(CustomElementCustomFlag);
+    m_nodeFlags = (m_nodeFlags & ~CustomElementStateMask)
+        | static_cast<NodeFlags>(newState);
     DCHECK(newState == getCustomElementState());
 
-    // When the state goes from Uncustomized to Undefined, and then to Custom,
-    // isDefined is always flipped.
+    if (isDefinedChanged) {
 #if DCHECK_IS_ON()
-    DCHECK_NE(wasDefined, toElement(this)->isDefined());
+        DCHECK_NE(wasDefined, toElement(this)->isDefined());
 #endif
-    toElement(this)->pseudoStateChanged(CSSSelector::PseudoDefined);
+        toElement(this)->pseudoStateChanged(CSSSelector::PseudoDefined);
+    }
 }
 
 void Node::setV0CustomElementState(V0CustomElementState newState)
 {
     V0CustomElementState oldState = getV0CustomElementState();
 
     switch (newState) {
     case V0NotCustomElement:
         ASSERT_NOT_REACHED(); // Everything starts in this state
         return;
@@ skipping 135 matching lines @@
 
 void showNodePath(const blink::Node* node)
 {
     if (node)
         node->showNodePathForThis();
     else
         fprintf(stderr, "Cannot showNodePath for (nil)\n");
 }
 
 #endif