Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2173373002: Revert "Use Timer and not AnimationFrame during Observatory UI tests" (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use Timer and not AnimationFrame during Observatory UI tests" This reverts commit ebbeff3d2cae521d1262bb41a3ac7b5cb1a08ec0. TBR=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/4dccbcaa0f8c6d4c73c3882185a12b059d166f20

Patch Set 1 #

Patch Set 2 : Revert "Use Timer and not AnimationFrame during Observatory UI tests" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -137 lines) Patch
M runtime/observatory/lib/src/elements/helpers/rendering_queue.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/curly_block/element_test.dart View 7 chunks +8 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/bar/element_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart View 2 chunks +1 line, -6 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.dart View 5 chunks +3 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.dart View 4 chunks +3 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/menu/element_test.dart View 4 chunks +3 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify/element_test.dart View 6 chunks +4 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.dart View 3 chunks +3 lines, -9 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart View 2 chunks +7 lines, -12 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_exception/exception_test.dart View 4 chunks +4 lines, -11 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/refresh/element_test.dart View 6 chunks +5 lines, -12 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/top-menu/element_test.dart View 4 chunks +2 lines, -6 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/vm_menu/element_test.dart View 6 chunks +3 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/view_footer/element_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.dart View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cbernaschina
4 years, 5 months ago (2016-07-24 23:11:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4dccbcaa0f8c6d4c73c3882185a12b059d166f20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698