Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.dart

Issue 2173373002: Revert "Use Timer and not AnimationFrame during Observatory UI tests" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Revert "Use Timer and not AnimationFrame during Observatory UI tests" Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.dart b/runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.dart
index 73f5e1fbd28e5fa5397f4ce2b93ec0aa0786d8aa..5d5de5c89f8afeb494ecff78d7e41ae83b8342fb 100644
--- a/runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.dart
@@ -5,15 +5,11 @@ import 'dart:html';
import 'dart:async';
import 'package:unittest/unittest.dart';
import 'package:observatory/mocks.dart';
-import 'package:observatory/src/elements/helpers/rendering_queue.dart';
import 'package:observatory/src/elements/nav/notify_event.dart';
main() {
NavNotifyEventElement.tag.ensureRegistration();
- final TimedRenderingBarrier barrier = new TimedRenderingBarrier();
- final RenderingQueue queue = new RenderingQueue.fromBarrier(barrier);
-
final PauseStartEventMock event = new PauseStartEventMock(
isolate: new IsolateMock(id: 'isolate-id', name: 'isolate-name'));
group('instantiation', () {
@@ -23,8 +19,7 @@ main() {
});
group('elements', () {
test('created after attachment', () async {
- final NavNotifyEventElement e = new NavNotifyEventElement(event,
- queue: queue);
+ final NavNotifyEventElement e = new NavNotifyEventElement(event);
document.body.append(e);
await e.onRendered.first;
expect(e.children.length, isNonZero, reason: 'has elements');
@@ -37,14 +32,13 @@ main() {
NavNotifyEventElement e;
StreamSubscription sub;
setUp(() async {
- e = new NavNotifyEventElement(event, queue: queue);
+ e = new NavNotifyEventElement(event);
document.body.append(e);
await e.onRendered.first;
});
- tearDown(() async {
+ tearDown(() {
sub.cancel();
e.remove();
- await e.onRendered.first;
});
test('navigation after connect', () async {
sub = window.onPopState.listen(expectAsync((_) {}, count: 1,

Powered by Google App Engine
This is Rietveld 408576698