Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.dart

Issue 2173373002: Revert "Use Timer and not AnimationFrame during Observatory UI tests" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Revert "Use Timer and not AnimationFrame during Observatory UI tests" Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/observatory_ui/view_footer/element_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.dart b/runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.dart
index 7410a233ab49c419c5ca59a261c2655da8eeea7e..d5c9080b9c54e034cccac3479e4d46979fee741d 100644
--- a/runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.dart
@@ -5,15 +5,11 @@ import 'dart:html';
import 'dart:async';
import 'package:unittest/unittest.dart';
import 'package:observatory/service_html.dart';
-import 'package:observatory/src/elements/helpers/rendering_queue.dart';
import 'package:observatory/src/elements/vm_connect_target.dart';
main() {
VMConnectTargetElement.tag.ensureRegistration();
- final TimedRenderingBarrier barrier = new TimedRenderingBarrier();
- final RenderingQueue queue = new RenderingQueue.fromBarrier(barrier);
-
WebSocketVMTarget t;
setUp(() {
t = new WebSocketVMTarget("a network address");
@@ -41,8 +37,7 @@ main() {
});
});
test('elements created after attachment', () async {
- final VMConnectTargetElement e = new VMConnectTargetElement(t,
- queue: queue);
+ final VMConnectTargetElement e = new VMConnectTargetElement(t);
document.body.append(e);
await e.onRendered.first;
expect(e.children.length, isNonZero, reason: 'has elements');
@@ -54,14 +49,13 @@ main() {
VMConnectTargetElement e;
StreamSubscription sub;
setUp(() async {
- e = new VMConnectTargetElement(t, queue: queue);
+ e = new VMConnectTargetElement(t);
document.body.append(e);
await e.onRendered.first;
});
- tearDown(() async {
+ tearDown(() {
sub.cancel();
e.remove();
- await e.onRendered.first;
});
test('navigation after connect', () async {
sub = window.onPopState.listen(expectAsync((_) {}, count: 1,
« no previous file with comments | « runtime/observatory/tests/observatory_ui/view_footer/element_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698