Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Unified Diff: runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.dart

Issue 2173373002: Revert "Use Timer and not AnimationFrame during Observatory UI tests" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Revert "Use Timer and not AnimationFrame during Observatory UI tests" Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.dart b/runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.dart
index 0e2bef674e891259b4738db5355e051c66f92f8f..f4ee551d2ee8f665174dee558fd1efe82c49d218 100644
--- a/runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.dart
@@ -3,15 +3,11 @@
// BSD-style license that can be found in the LICENSE file.
import 'dart:html';
import 'package:unittest/unittest.dart';
-import 'package:observatory/src/elements/helpers/rendering_queue.dart';
import 'package:observatory/src/elements/nav/menu_item.dart';
main() {
NavMenuItemElement.tag.ensureRegistration();
- final TimedRenderingBarrier barrier = new TimedRenderingBarrier();
- final RenderingQueue queue = new RenderingQueue.fromBarrier(barrier);
-
group('instantiation', () {
final label = 'custom-label';
final link = 'link-to-target';
@@ -29,7 +25,7 @@ main() {
group('elements', () {
test('created', () async {
final label = 'custom-label';
- final NavMenuItemElement e = new NavMenuItemElement(label, queue: queue);
+ final NavMenuItemElement e = new NavMenuItemElement(label);
document.body.append(e);
await e.onRendered.first;
expect(e.shadowRoot.children.length, isNonZero, reason: 'has elements');
@@ -42,7 +38,7 @@ main() {
test('react to label change', () async {
final label1 = 'custom-label-1';
final label2 = 'custom-label-2';
- final NavMenuItemElement e = new NavMenuItemElement(label1, queue: queue);
+ final NavMenuItemElement e = new NavMenuItemElement(label1);
document.body.append(e);
await e.onRendered.first;
expect(e.shadowRoot.innerHtml.contains(label1), isTrue);
@@ -58,8 +54,7 @@ main() {
final label = 'custom-label';
final link1 = 'custom-label-1';
final link2 = 'custom-label-2';
- final NavMenuItemElement e = new NavMenuItemElement(label, link: link1,
- queue: queue);
+ final NavMenuItemElement e = new NavMenuItemElement(label, link: link1);
document.body.append(e);
await e.onRendered.first;
expect(e.shadowRoot.innerHtml.contains(link1), isTrue);

Powered by Google App Engine
This is Rietveld 408576698