Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: runtime/observatory/tests/observatory_ui/nav/top-menu/element_test.dart

Issue 2173373002: Revert "Use Timer and not AnimationFrame during Observatory UI tests" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Revert "Use Timer and not AnimationFrame during Observatory UI tests" Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/nav/top-menu/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/nav/top-menu/element_test.dart b/runtime/observatory/tests/observatory_ui/nav/top-menu/element_test.dart
index 8d6e8e766de26772fd30320ceaf8e95d07d95036..df9f88c938fc0b8074133c9ed8c3e929751dd807 100644
--- a/runtime/observatory/tests/observatory_ui/nav/top-menu/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/nav/top-menu/element_test.dart
@@ -3,7 +3,6 @@
// BSD-style license that can be found in the LICENSE file.
import 'dart:html';
import 'package:unittest/unittest.dart';
-import 'package:observatory/src/elements/helpers/rendering_queue.dart';
import 'package:observatory/src/elements/nav/menu.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
@@ -12,8 +11,6 @@ main() {
final String tag = NavMenuElement.tag.name;
- final TimedRenderingBarrier barrier = new TimedRenderingBarrier();
- final RenderingQueue queue = new RenderingQueue.fromBarrier(barrier);
group('instantiation', () {
test('default', () {
final NavTopMenuElement e = new NavTopMenuElement();
@@ -32,7 +29,7 @@ main() {
});
group('elements', () {
test('created', () async {
- final NavTopMenuElement e = new NavTopMenuElement(queue: queue);
+ final NavTopMenuElement e = new NavTopMenuElement();
document.body.append(e);
await e.onRendered.first;
expect(e.shadowRoot.children.length, isNonZero, reason: 'has elements');
@@ -43,8 +40,7 @@ main() {
expect(e.shadowRoot.children.length, isZero, reason: 'is empty');
});
test('react to last change', () async {
- final NavTopMenuElement e = new NavTopMenuElement(last: false,
- queue: queue);
+ final NavTopMenuElement e = new NavTopMenuElement(last: false);
document.body.append(e);
await e.onRendered.first;
expect((e.shadowRoot.querySelector(tag) as NavMenuElement).last, isFalse);

Powered by Google App Engine
This is Rietveld 408576698