Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths

Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths

This is more consistent overall, GetGLImplementation() doesn't tell exactly
whether we're using the core profile, or which version of ES etc.
It also helps testing & fuzzing, because mocks/stubs may implement ES2 but don't
report kGLImplementationEGLGLES2, causing inconsistencies.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/9b0c43932354d90f3d5e4882695f442bbbb4708c
Cr-Commit-Position: refs/heads/master@{#407276}

[piman, 2016-07-22 04:10:34]

Description was changed from

==========
Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths

This is more consistent overall, GetGLImplementation() doesn't tell exactly
whether we're using the core profile, or which version of ES etc.
It also helps testing & fuzzing, because mocks/stubs may implement ES2 but don't
report kGLImplementationEGLGLES2, causing inconsistencies.

BUG=None
==========

to

==========
Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths

This is more consistent overall, GetGLImplementation() doesn't tell exactly
whether we're using the core profile, or which version of ES etc.
It also helps testing & fuzzing, because mocks/stubs may implement ES2 but don't
report kGLImplementationEGLGLES2, causing inconsistencies.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-07-22 04:11:34]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 04:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-07-22 04:14:13]

piman@chromium.org changed reviewers:
+ sievers@chromium.org

[commit-bot: I haz the power, 2016-07-22 05:11:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 05:11:28]

Dry run: This issue passed the CQ dry run.

[no sievers, 2016-07-22 17:26:18]

lgtm

https://codereview.chromium.org/2170293002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/buffer_manager.cc (right):

https://codereview.chromium.org/2170293002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/buffer_manager.cc:362: !feature_info_ ||
feature_info_->gl_version_info().is_es;
|!feature_info_| is for some unit tests?
maybe worth a comment.

[piman, 2016-07-22 17:30:03]

Thanks!

https://codereview.chromium.org/2170293002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/buffer_manager.cc (right):

https://codereview.chromium.org/2170293002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/buffer_manager.cc:362: !feature_info_ ||
feature_info_->gl_version_info().is_es;
On 2016/07/22 17:26:17, sievers wrote:
> |!feature_info_| is for some unit tests?
> maybe worth a comment.

It is (that's not ideal, but same as UseNonZeroSizeForClientSideArrayBuffer),
I'll add a comment.

[piman, 2016-07-22 19:08:42]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-22 19:08:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2170293002/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2016-07-22 19:09:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-07-22 19:25:37]

https://codereview.chromium.org/2170293002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/buffer_manager.cc (right):

https://codereview.chromium.org/2170293002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/buffer_manager.cc:362: !feature_info_ ||
feature_info_->gl_version_info().is_es;
On 2016/07/22 17:26:17, sievers wrote:
> |!feature_info_| is for some unit tests?
> maybe worth a comment.

Done.

[commit-bot: I haz the power, 2016-07-22 21:58:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 22:00:09]

Description was changed from

==========
Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths

This is more consistent overall, GetGLImplementation() doesn't tell exactly
whether we're using the core profile, or which version of ES etc.
It also helps testing & fuzzing, because mocks/stubs may implement ES2 but don't
report kGLImplementationEGLGLES2, causing inconsistencies.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths

This is more consistent overall, GetGLImplementation() doesn't tell exactly
whether we're using the core profile, or which version of ES etc.
It also helps testing & fuzzing, because mocks/stubs may implement ES2 but don't
report kGLImplementationEGLGLES2, causing inconsistencies.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/9b0c43932354d90f3d5e4882695f442bbbb4708c
Cr-Commit-Position: refs/heads/master@{#407276}
==========

[commit-bot: I haz the power, 2016-07-22 22:00:10]

Patchset 2 (id:??) landed as
https://crrev.com/9b0c43932354d90f3d5e4882695f442bbbb4708c
Cr-Commit-Position: refs/heads/master@{#407276}