Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths

gpu/command_buffer/service/buffer_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/buffer_manager.h"
 
 #include <stdint.h>
 
 #include <limits>
 
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/trace_event/memory_dump_manager.h"
 #include "base/trace_event/trace_event.h"
 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
 #include "gpu/command_buffer/service/context_state.h"
 #include "gpu/command_buffer/service/error_state.h"
 #include "gpu/command_buffer/service/feature_info.h"
 #include "gpu/command_buffer/service/memory_tracking.h"
 #include "gpu/command_buffer/service/transform_feedback_manager.h"
 #include "ui/gl/gl_bindings.h"
-#include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_version_info.h"
 #include "ui/gl/trace_util.h"
 
 namespace gpu {
 namespace gles2 {
 namespace {
 static const GLsizeiptr kDefaultMaxBufferSize = 1u << 30;  // 1GB
 }
 
 BufferManager::BufferManager(MemoryTracker* memory_tracker,
@@ skipping 318 matching lines @@
 
 bool BufferManager::UseNonZeroSizeForClientSideArrayBuffer() {
   return feature_info_.get() &&
          feature_info_->workarounds()
              .use_non_zero_size_for_client_side_stream_buffers;
 }
 
 bool BufferManager::UseShadowBuffer(GLenum target, GLenum usage) {
   const bool is_client_side_array = IsUsageClientSideArray(usage);
   const bool support_fixed_attribs =
-      gl::GetGLImplementation() == gl::kGLImplementationEGLGLES2;
+      !feature_info_ || feature_info_->gl_version_info().is_es;

[no sievers, 2016/07/22 17:26:17]

|!feature_info_| is for some unit tests?
maybe worth a comment.

[piman, 2016/07/22 17:30:02]

It is (that's not ideal, but same as UseNonZeroSizeForClientSideArrayBuffer),
I'll add a comment.

[piman, 2016/07/22 19:25:37]

Done.

 
   // TODO(zmo): Don't shadow buffer data on ES3. crbug.com/491002.
   return (
       target == GL_ELEMENT_ARRAY_BUFFER || allow_buffers_on_multiple_targets_ ||
       (allow_fixed_attribs_ && !support_fixed_attribs) || is_client_side_array);
 }
 
 void BufferManager::SetInfo(Buffer* buffer,
                             GLenum target,
                             GLsizeiptr size,
@@ skipping 287 matching lines @@
     auto guid = gl::GetGLBufferGUIDForTracing(share_group_tracing_guid,
                                               client_buffer_id);
     pmd->CreateSharedGlobalAllocatorDump(guid);
     pmd->AddOwnershipEdge(dump->guid(), guid);
   }
   return true;
 }
 
 }  // namespace gles2
 }  // namespace gpu