Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2165873002: Validate UniformBlocks being backed by sufficient data (Closed)

Created:
4 years, 5 months ago by Zhenyao Mo
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Ken Russell (switch to Gerrit), Corentin Wallez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Validate UniformBlocks being backed by sufficient data BUG=628863 TEST=gpu_unittests, webgl2_conformance R=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/f86e79e06e8d874f7e67c3eb2ff717a8c7887c42 Cr-Commit-Position: refs/heads/master@{#406707}

Patch Set 1 #

Patch Set 2 : Fix a bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -30 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 6 chunks +48 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 9 chunks +40 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/indexed_buffer_binding_host.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/indexed_buffer_binding_host.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 4 chunks +16 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 2 chunks +34 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (13 generated)
Zhenyao Mo
piman: Please review. Others: FYI
4 years, 5 months ago (2016-07-20 01:30:57 UTC) #5
Zhenyao Mo
Bots all green. Please take a look.
4 years, 5 months ago (2016-07-20 18:19:06 UTC) #12
piman
lgtm
4 years, 5 months ago (2016-07-20 23:07:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165873002/20001
4 years, 5 months ago (2016-07-20 23:21:38 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 23:27:02 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 23:28:17 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f86e79e06e8d874f7e67c3eb2ff717a8c7887c42
Cr-Commit-Position: refs/heads/master@{#406707}

Powered by Google App Engine
This is Rietveld 408576698