gpu/command_buffer/service/indexed_buffer_binding_host.h - Issue 2165873002: Validate UniformBlocks being backed by sufficient data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/indexed_buffer_binding_host.h

Issue 2165873002: Validate UniformBlocks being backed by sufficient data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a bug Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc ('k') | gpu/command_buffer/service/indexed_buffer_binding_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/indexed_buffer_binding_host.h

diff --git a/gpu/command_buffer/service/indexed_buffer_binding_host.h b/gpu/command_buffer/service/indexed_buffer_binding_host.h

index 54e88569e1b377946becc43ab9b5aaa838a7e646..3730069917f2a1ff176c102eef7f1d5281e463b1 100644

--- a/gpu/command_buffer/service/indexed_buffer_binding_host.h

+++ b/gpu/command_buffer/service/indexed_buffer_binding_host.h

@@ -43,7 +43,13 @@ class GPU_EXPORT IndexedBufferBindingHost :

void RemoveBoundBuffer(Buffer* buffer);

Buffer* GetBufferBinding(GLuint index) const;

+ // Returns |size| set by glBindBufferRange; 0 if set by glBindBufferBase.

GLsizeiptr GetBufferSize(GLuint index) const;

+ // For glBindBufferBase, return the actual buffer size when this function is

+ // called, not when glBindBufferBase is called.

+ // For glBindBufferRange, return the |size| set by glBindBufferRange minus

+ // the range that's beyond the buffer.

+ GLsizeiptr GetEffectiveBufferSize(GLuint index) const;

GLintptr GetBufferStart(GLuint index) const;

// This is used only for UNIFORM_BUFFER bindings in context switching.