Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: gpu/command_buffer/service/indexed_buffer_binding_host.cc

Issue 2165873002: Validate UniformBlocks being backed by sufficient data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a bug Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/indexed_buffer_binding_host.cc
diff --git a/gpu/command_buffer/service/indexed_buffer_binding_host.cc b/gpu/command_buffer/service/indexed_buffer_binding_host.cc
index fb5c11ba94c0fd9b79c5f8b574fca39422f15cba..351e5f4a5edda715c88c7f34b1a58be9770e3900 100644
--- a/gpu/command_buffer/service/indexed_buffer_binding_host.cc
+++ b/gpu/command_buffer/service/indexed_buffer_binding_host.cc
@@ -195,6 +195,26 @@ GLsizeiptr IndexedBufferBindingHost::GetBufferSize(GLuint index) const {
return buffer_bindings_[index].size;
}
+GLsizeiptr IndexedBufferBindingHost::GetEffectiveBufferSize(
+ GLuint index) const {
+ DCHECK_LT(index, buffer_bindings_.size());
+ const IndexedBufferBinding& binding = buffer_bindings_[index];
+ if (!binding.buffer.get())
+ return 0;
+ GLsizeiptr full_buffer_size = binding.buffer->size();
+ switch (binding.type) {
+ case kBindBufferBase:
+ return full_buffer_size;
+ case kBindBufferRange:
+ if (binding.offset + binding.size > full_buffer_size)
+ return full_buffer_size - binding.offset;
+ return binding.size;
+ case kBindBufferNone:
+ return 0;
+ }
+ return buffer_bindings_[index].size;
+}
+
GLintptr IndexedBufferBindingHost::GetBufferStart(GLuint index) const {
DCHECK_LT(index, buffer_bindings_.size());
return buffer_bindings_[index].offset;
« no previous file with comments | « gpu/command_buffer/service/indexed_buffer_binding_host.h ('k') | gpu/command_buffer/service/program_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698