MD Settings: Replace paper-item with button under iron-dropdown, part1.

MD Settings: Replace paper-item with button under iron-dropdown, part1.

Remaining paper-item references will be removed in part2.

BUG=602896
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/73d0796f5409a410d37b5fb02c41c7c848f61077
Cr-Commit-Position: refs/heads/master@{#406462}

[dpapad, 2016-07-19 01:28:23]

Description was changed from

==========
MD Settings: Replace paper-item with button under iron-dropdown, part1.

BUG=
==========

to

==========
MD Settings: Replace paper-item with button under iron-dropdown, part1.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-19 01:29:54]

Description was changed from

==========
MD Settings: Replace paper-item with button under iron-dropdown, part1.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Replace paper-item with button under iron-dropdown, part1.

BUG=602896
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-19 01:30:01]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 01:31:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-07-19 01:31:15]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 01:32:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-07-19 01:33:24]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 01:34:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 02:44:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:44:15]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-07-19 18:30:19]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2016-07-19 18:30:19]

There should be no visual change by this CL.
Before: https://screenshot.googleplex.com/zGTD9dQQMmX
After: https://screenshot.googleplex.com/TLJfwAcmUbD

[michaelpg, 2016-07-19 21:48:31]

https://codereview.chromium.org/2162803002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
(right):

https://codereview.chromium.org/2162803002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html:46:
<button class="dropdown-item" id="view" on-tap="onViewTap_">
all these need role="option" (PaperItemBehavior adds it to paper-item
automagically)

[dpapad, 2016-07-19 22:04:54]

https://codereview.chromium.org/2162803002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
(right):

https://codereview.chromium.org/2162803002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html:46:
<button class="dropdown-item" id="view" on-tap="onViewTap_">
On 2016/07/19 at 21:48:31, michaelpg wrote:
> all these need role="option" (PaperItemBehavior adds it to paper-item
automagically)

Done.

[michaelpg, 2016-07-19 23:30:45]

lgtm

what makes this "part1"? what's missing/what's the next part? can you update the
description w/ that?

[dpapad, 2016-07-19 23:38:00]

Description was changed from

==========
MD Settings: Replace paper-item with button under iron-dropdown, part1.

BUG=602896
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Replace paper-item with button under iron-dropdown, part1.

Remaining paper-item references will be removed in part2.

BUG=602896
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-19 23:38:42]

On 2016/07/19 at 23:30:45, michaelpg wrote:
> lgtm
> 
> what makes this "part1"? what's missing/what's the next part? can you update
the description w/ that?

paper-item is still used under the following files. Will follow up with those in
separate CL (updated CL description).

site_settings/site_list.html
site_settings/protocol_handlers.html
site_settings/site_details.html
site_settings/site_settings_category.html
bluetooth_page/bluetooth_device_list_item.html

[dpapad, 2016-07-19 23:52:56]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-07-19 23:53:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 00:36:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 00:36:20]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dpapad, 2016-07-20 00:51:06]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-07-20 00:51:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2162803002/#ps100001
(title: "Fix failing ChromeOS test.")

[commit-bot: I haz the power, 2016-07-20 00:52:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 02:14:27]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-20 02:14:31]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 02:16:19]

Description was changed from

==========
MD Settings: Replace paper-item with button under iron-dropdown, part1.

Remaining paper-item references will be removed in part2.

BUG=602896
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Replace paper-item with button under iron-dropdown, part1.

Remaining paper-item references will be removed in part2.

BUG=602896
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/73d0796f5409a410d37b5fb02c41c7c848f61077
Cr-Commit-Position: refs/heads/master@{#406462}
==========

[commit-bot: I haz the power, 2016-07-20 02:16:20]

Patchset 6 (id:??) landed as
https://crrev.com/73d0796f5409a410d37b5fb02c41c7c848f61077
Cr-Commit-Position: refs/heads/master@{#406462}