chrome/browser/resources/settings/search_engines_page/search_engine_entry.html - Issue 2162803002: MD Settings: Replace paper-item with button under iron-dropdown, part1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

Issue 2162803002: MD Settings: Replace paper-item with button under iron-dropdown, part1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing ChromeOS test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.css ('k') | chrome/browser/resources/settings/settings_shared_css.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

index 0e602baa589f228f0a4883e6a3155e94c0ec1038..30db2a4913f1e9b09c0ba5f7f0b1cff29387b29a 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

@@ -3,7 +3,6 @@

-<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">

@@ -48,14 +47,16 @@

<iron-dropdown opened="{{editMenuOpened}}" horizontal-align="right"

vertical-align="auto">

- <paper-item on-tap="onMakeDefaultTap_"

+ <button class="dropdown-item" role="option" on-tap="onMakeDefaultTap_"

hidden$="[[!engine.canBeDefault]]" id="makeDefault">

$i18n{searchEnginesMakeDefault}

- </paper-item>

- <paper-item on-tap="onEditTap_" hidden$="[[!engine.canBeEdited]]"

- id="edit">$i18n{searchEnginesEdit}</paper-item>

- <paper-item on-tap="onDeleteTap_" hidden$="[[!engine.canBeRemoved]]"

- id="delete">$i18n{searchEnginesRemoveFromList}</paper-item>

+ </button>

+ <button class="dropdown-item" role="option" on-tap="onEditTap_"

+ hidden$="[[!engine.canBeEdited]]"

+ id="edit">$i18n{searchEnginesEdit}</button>

+ <button class="dropdown-item" role="option" on-tap="onDeleteTap_"

+ hidden$="[[!engine.canBeRemoved]]"

+ id="delete">$i18n{searchEnginesRemoveFromList}</button>

<div>

</iron-dropdown>

</div>