Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: chrome/browser/resources/settings/on_startup_page/startup_url_entry.html

Issue 2162803002: MD Settings: Replace paper-item with button under iron-dropdown, part1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing ChromeOS test. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/html/icon.html"> 3 <link rel="import" href="chrome://resources/html/icon.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">
7 <link rel="import" href="/on_startup_page/startup_urls_page_browser_proxy.html"> 6 <link rel="import" href="/on_startup_page/startup_urls_page_browser_proxy.html">
8 <link rel="import" href="/settings_shared_css.html"> 7 <link rel="import" href="/settings_shared_css.html">
9 8
10 <dom-module id="settings-startup-url-entry"> 9 <dom-module id="settings-startup-url-entry">
11 <template> 10 <template>
12 <style include="settings-shared"> 11 <style include="settings-shared">
13 .hide-overflow { 12 .hide-overflow {
14 overflow: hidden; 13 overflow: hidden;
15 } 14 }
16 </style> 15 </style>
17 <div class="list-item underbar"> 16 <div class="list-item underbar">
18 <div class="favicon-image" 17 <div class="favicon-image"
19 style="background-image: [[getIconSet_(model.url)]]"> 18 style="background-image: [[getIconSet_(model.url)]]">
20 </div> 19 </div>
21 <div class="middle hide-overflow"> 20 <div class="middle hide-overflow">
22 <div class="text-elide">[[model.title]]</div> 21 <div class="text-elide">[[model.title]]</div>
23 <div class="text-elide secondary">[[model.url]]</div> 22 <div class="text-elide secondary">[[model.url]]</div>
24 </div> 23 </div>
25 <paper-icon-button id="dots" icon="cr:more-vert" toggles 24 <paper-icon-button id="dots" icon="cr:more-vert" toggles
26 active="{{menuOpened}}"></paper-icon-button> 25 active="{{menuOpened}}"></paper-icon-button>
27 <template is="dom-if" if="[[menuOpened]]"> 26 <template is="dom-if" if="[[menuOpened]]">
28 <iron-dropdown vertical-align="auto" horizontal-align="right" 27 <iron-dropdown vertical-align="auto" horizontal-align="right"
29 opened="{{menuOpened}}"> 28 opened="{{menuOpened}}">
30 <div class="dropdown-content"> 29 <div class="dropdown-content">
31 <paper-item on-tap="onEditTap_">$i18n{onStartupEdit}</paper-item> 30 <button class="dropdown-item" role="option" on-tap="onEditTap_">
32 <paper-item id="remove" on-tap="onRemoveTap_"> 31 $i18n{onStartupEdit}
32 </button>
33 <button class="dropdown-item" role="option" id="remove"
34 on-tap="onRemoveTap_">
33 $i18n{onStartupRemove} 35 $i18n{onStartupRemove}
34 </paper-item> 36 </button>
35 </div> 37 </div>
36 </iron-dropdown> 38 </iron-dropdown>
37 </template> 39 </template>
38 </div> 40 </div>
39 </template> 41 </template>
40 <script src="startup_url_entry.js"></script> 42 <script src="startup_url_entry.js"></script>
41 </dom-module> 43 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698