chrome/browser/resources/settings/languages_page/languages_page.html - Issue 2162803002: MD Settings: Replace paper-item with button under iron-dropdown, part1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2162803002: MD Settings: Replace paper-item with button under iron-dropdown, part1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing ChromeOS test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html ('k') | chrome/browser/resources/settings/on_startup_page/startup_url_entry.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/languages_page.html

diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html

index 732c2702c176ec06b3b02acd5eef5bbcb9afe466..b5da57fb09b28f3237e2a392a9823c28670c9e28 100644

--- a/chrome/browser/resources/settings/languages_page/languages_page.html

+++ b/chrome/browser/resources/settings/languages_page/languages_page.html

@@ -83,20 +83,22 @@

<iron-dropdown opened="{{item.optionsMenuOpened}}"

horizontal-align="right" vertical-align="auto">

- <paper-item on-tap="onMoveUpTap_"

+ <button class="dropdown-item" role="option"

+ on-tap="onMoveUpTap_"

hidden="[[isFirstLanguage_(index,

languages.enabled.*)]]">

$i18n{moveUp}

- </paper-item>

- <paper-item on-tap="onMoveDownTap_"

+ </button>

+ <button class="dropdown-item" role="option"

+ on-tap="onMoveDownTap_"

hidden="[[isLastLanguage_(index,

languages.enabled.*)]]">

$i18n{moveDown}

- </paper-item>

- <paper-item class="language-detail-item"

+ </button>

+ <button class="dropdown-item" role="option"

on-tap="onShowLanguageDetailTap_">

$i18n{languageDetail}

- </paper-item>

+ </button>

</div>

</iron-dropdown>

</div>