Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

Issue 2162803002: MD Settings: Replace paper-item with button under iron-dropdown, part1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing ChromeOS test. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/html/icon.html"> 3 <link rel="import" href="chrome://resources/html/icon.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">
7 <link rel="import" href="/search_engines_page/search_engine_dialog.html"> 6 <link rel="import" href="/search_engines_page/search_engine_dialog.html">
8 <link rel="import" href="/search_engines_page/search_engines_browser_proxy.html" > 7 <link rel="import" href="/search_engines_page/search_engines_browser_proxy.html" >
9 <link rel="import" href="/settings_shared_css.html"> 8 <link rel="import" href="/settings_shared_css.html">
10 9
11 <dom-module id="settings-search-engine-entry"> 10 <dom-module id="settings-search-engine-entry">
12 <link rel="import" type="css" href="/search_engines_page/search_engine_entry.c ss"> 11 <link rel="import" type="css" href="/search_engines_page/search_engine_entry.c ss">
13 <template> 12 <template>
14 <style include="settings-shared"></style> 13 <style include="settings-shared"></style>
15 <style> 14 <style>
16 :host([is-default]) { 15 :host([is-default]) {
(...skipping 24 matching lines...) Expand all
41 <span class="name">[[engine.displayName]]</span> 40 <span class="name">[[engine.displayName]]</span>
42 </div> 41 </div>
43 <div class="keyword-column">[[engine.keyword]]</div> 42 <div class="keyword-column">[[engine.keyword]]</div>
44 <div class="url-column">[[engine.url]]</div> 43 <div class="url-column">[[engine.url]]</div>
45 <paper-icon-button icon="cr:more-vert" toggles 44 <paper-icon-button icon="cr:more-vert" toggles
46 active="{{editMenuOpened}}"> 45 active="{{editMenuOpened}}">
47 </paper-icon-button> 46 </paper-icon-button>
48 <iron-dropdown opened="{{editMenuOpened}}" horizontal-align="right" 47 <iron-dropdown opened="{{editMenuOpened}}" horizontal-align="right"
49 vertical-align="auto"> 48 vertical-align="auto">
50 <div class="dropdown-content"> 49 <div class="dropdown-content">
51 <paper-item on-tap="onMakeDefaultTap_" 50 <button class="dropdown-item" role="option" on-tap="onMakeDefaultTap_"
52 hidden$="[[!engine.canBeDefault]]" id="makeDefault"> 51 hidden$="[[!engine.canBeDefault]]" id="makeDefault">
53 $i18n{searchEnginesMakeDefault} 52 $i18n{searchEnginesMakeDefault}
54 </paper-item> 53 </button>
55 <paper-item on-tap="onEditTap_" hidden$="[[!engine.canBeEdited]]" 54 <button class="dropdown-item" role="option" on-tap="onEditTap_"
56 id="edit">$i18n{searchEnginesEdit}</paper-item> 55 hidden$="[[!engine.canBeEdited]]"
57 <paper-item on-tap="onDeleteTap_" hidden$="[[!engine.canBeRemoved]]" 56 id="edit">$i18n{searchEnginesEdit}</button>
58 id="delete">$i18n{searchEnginesRemoveFromList}</paper-item> 57 <button class="dropdown-item" role="option" on-tap="onDeleteTap_"
58 hidden$="[[!engine.canBeRemoved]]"
59 id="delete">$i18n{searchEnginesRemoveFromList}</button>
59 <div> 60 <div>
60 </iron-dropdown> 61 </iron-dropdown>
61 </div> 62 </div>
62 </template> 63 </template>
63 <script src="search_engine_entry.js"></script> 64 <script src="search_engine_entry.js"></script>
64 </dom-module> 65 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698