On Linux rework driver_version/vendor extraction from gl version

On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929
R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
Committed: https://crrev.com/84e4f0e4b82370e00bfc07cb05c489783b219bee
Cr-Original-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Original-Commit-Position: refs/heads/master@{#408604}
Cr-Commit-Position: refs/heads/master@{#411568}

[Julien Isorce Samsung, 2016-07-17 13:35:38]

Description was changed from

==========
Omit '(Core Profile)' from GpuInfo.gl_version in CollectDriverInfoGL

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
==========

to

==========
Omit '(Core Profile)' from GpuInfo.gl_version in CollectDriverInfoGL

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce Samsung, 2016-07-17 13:36:05]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-17 13:36:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-17 14:00:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-17 14:00:04]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[patyag0814, 2016-07-17 17:09:36]

patyag0814@gmail.com changed reviewers:
+ patyag0814@gmail.com

[Zhenyao Mo, 2016-07-17 17:37:53]

On 2016/07/17 17:12:54, patyag0814 wrote:

We should fix the driver version extraction code to be more flexible rather than
change the verison string.

[Julien Isorce Samsung, 2016-07-17 18:18:22]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-17 18:18:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-17 18:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-17 18:42:21]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Julien Isorce Samsung, 2016-07-17 21:16:29]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-17 21:16:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-17 21:37:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-17 21:37:30]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Julien Isorce Samsung, 2016-07-18 06:42:06]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 06:42:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 07:02:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 07:02:13]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Julien Isorce Samsung, 2016-07-18 11:29:18]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 11:29:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 11:50:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 11:50:46]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ken Russell (switch to Gerrit), 2016-07-18 18:45:24]

On 2016/07/17 17:37:53, Zhenyao Mo wrote:
> On 2016/07/17 17:12:54, patyag0814 wrote:
> 
> We should fix the driver version extraction code to be more flexible rather
than
> change the verison string.

Agreed.

[Julien Isorce Samsung, 2016-07-19 09:11:27]

On 2016/07/18 18:45:24, Ken Russell wrote:
> On 2016/07/17 17:37:53, Zhenyao Mo wrote:
> > On 2016/07/17 17:12:54, patyag0814 wrote:
> > 
> > We should fix the driver version extraction code to be more flexible rather
> than
> > change the verison string.
> 
> Agreed.

So is the CL ok ? Not sure to follow since I cannot see @patyag0814 comments.

[Julien Isorce Samsung, 2016-07-19 09:11:41]

Description was changed from

==========
Omit '(Core Profile)' from GpuInfo.gl_version in CollectDriverInfoGL

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Omit '(Core Profile)' from GpuInfo.gl_version in CollectDriverInfoGL

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce Samsung, 2016-07-19 09:11:41]

j.isorce@samsung.com changed reviewers:
+ cwallez@chromium.org

[Julien Isorce Samsung, 2016-07-19 09:14:51]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 09:15:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 10:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 10:20:37]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Julien Isorce Samsung, 2016-07-19 14:15:14]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 14:15:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 14:36:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 14:36:59]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Julien Isorce Samsung, 2016-07-20 05:00:48]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 05:00:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 06:09:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 06:09:36]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-07-20 21:53:16]

Hi, I fixed the CL but I plan to add a unit test for it,
probably around GpuDataManagerImplPrivateTest_SetGLStrings
from gpu_data_manager_impl_private_unittest.cc .

[Ken Russell (switch to Gerrit), 2016-07-20 23:59:29]

On 2016/07/20 21:53:16, Julien Isorce wrote:
> Hi, I fixed the CL but I plan to add a unit test for it,
> probably around GpuDataManagerImplPrivateTest_SetGLStrings
> from gpu_data_manager_impl_private_unittest.cc .

I see, this doesn't modify the reported gl_version string, just fixes the
detection for when it's the core profile.

Looks OK; please add a unit test. Thanks.

[Julien Isorce Samsung, 2016-07-21 08:03:05]

Description was changed from

==========
Omit '(Core Profile)' from GpuInfo.gl_version in CollectDriverInfoGL

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Omit '(Core Profile)' from GpuInfo.gl_version in CollectDriverInfoGL

This allow to select entries from kGpuDriverBugListJson
that relies on "driver_vendor": "Mesa" .
Previously there were not selected if gl version
contains the '(Core Profile)' string.

This allow to properly extract driver version and driver
vendor from a gl version that contains the '(Core Profile)' string.

Example: 
"3.3 (Core Profile) Mesa 10.5.9"

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
==========

[Julien Isorce Samsung, 2016-07-21 08:03:20]

On 2016/07/20 23:59:29, Ken Russell wrote:
> On 2016/07/20 21:53:16, Julien Isorce wrote:
> > Hi, I fixed the CL but I plan to add a unit test for it,
> > probably around GpuDataManagerImplPrivateTest_SetGLStrings
> > from gpu_data_manager_impl_private_unittest.cc .
> 
> I see, this doesn't modify the reported gl_version string, just fixes the
> detection for when it's the core profile.
> 
> Looks OK; please add a unit test. Thanks.

Done.

[Julien Isorce Samsung, 2016-07-21 08:03:30]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 08:03:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 08:43:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 08:43:40]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-07-21 13:30:44]

lgtm

https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector_linux.cc (right):

https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector_linux.cc:253: std::string core_profile = "(Core
Profile)";
I guess this is ok, but a more generic fix is you always use the last piece
after SplitString for driver version instead of pieces[2].

[Julien Isorce Samsung, 2016-07-21 13:56:37]

https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector_linux.cc (right):

https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector_linux.cc:253: std::string core_profile = "(Core
Profile)";
On 2016/07/21 13:30:44, Zhenyao Mo wrote:
> I guess this is ok, but a more generic fix is you always use the last piece
> after SplitString for driver version instead of pieces[2].

Good idea, thx, and driver_vendor would be the last-1 piece, right ?

[Zhenyao Mo, 2016-07-21 13:59:47]

https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector_linux.cc (right):

https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector_linux.cc:253: std::string core_profile = "(Core
Profile)";
On 2016/07/21 13:56:36, Julien Isorce wrote:
> On 2016/07/21 13:30:44, Zhenyao Mo wrote:
> > I guess this is ok, but a more generic fix is you always use the last piece
> > after SplitString for driver version instead of pieces[2].
> 
> Good idea, thx, and driver_vendor would be the last-1 piece, right ?

right

[Julien Isorce Samsung, 2016-07-21 23:12:48]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 23:13:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julien Isorce Samsung, 2016-07-21 23:18:04]

On 2016/07/21 13:59:47, Zhenyao Mo wrote:
>
https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_col...
> File gpu/config/gpu_info_collector_linux.cc (right):
> 
>
https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_col...
> gpu/config/gpu_info_collector_linux.cc:253: std::string core_profile = "(Core
> Profile)";
> On 2016/07/21 13:56:36, Julien Isorce wrote:
> > On 2016/07/21 13:30:44, Zhenyao Mo wrote:
> > > I guess this is ok, but a more generic fix is you always use the last
piece
> > > after SplitString for driver version instead of pieces[2].
> > 
> > Good idea, thx, and driver_vendor would be the last-1 piece, right ?
> 
> right

Since gl_version can be also "3.0 Mesa 12.1.0-devel (git-ed9dd3b)" it would not
have worked to take the last piece to extract the driver version. So I decided
to take the last piece that starts with digits instead.
And driver_vendor is extracted from the piece just before.

Please have a look. Thx.

[Ken Russell (switch to Gerrit), 2016-07-21 23:54:55]

https://codereview.chromium.org/2153373002/diff/100001/gpu/config/gpu_info_co...
File gpu/config/gpu_info_collector_linux.cc (right):

https://codereview.chromium.org/2153373002/diff/100001/gpu/config/gpu_info_co...
gpu/config/gpu_info_collector_linux.cc:258: // Search from the end for the first
piece that contains at least one digit.
Why not just use a regexp? Something which matches

  [0-9].[0-9](.[0-9])?.*

I think this should be looking for something which starts with a number, but
that could be conflated with the git hashes. Let's just do something better.

https://codereview.chromium.org/2153373002/diff/100001/gpu/config/gpu_info_co...
gpu/config/gpu_info_collector_linux.cc:262: while (it + 2 != pieces.rend()) {
This looks risky. Please do something else which is more resilient to
out-of-bounds accesses. Perhaps 

  while (pieces.rend() - it > 2) {
  }

[commit-bot: I haz the power, 2016-07-22 01:17:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 01:17:01]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-07-22 07:38:29]

Thx for the suggestions, I uploaded new patch set, please have a look, thx.

https://codereview.chromium.org/2153373002/diff/100001/gpu/config/gpu_info_co...
File gpu/config/gpu_info_collector_linux.cc (right):

https://codereview.chromium.org/2153373002/diff/100001/gpu/config/gpu_info_co...
gpu/config/gpu_info_collector_linux.cc:258: // Search from the end for the first
piece that contains at least one digit.
On 2016/07/21 23:54:54, Ken Russell wrote:
> Why not just use a regexp? Something which matches
> 
>   [0-9].[0-9](.[0-9])?.*
> 
> I think this should be looking for something which starts with a number, but
> that could be conflated with the git hashes. Let's just do something better.

Done.

https://codereview.chromium.org/2153373002/diff/100001/gpu/config/gpu_info_co...
gpu/config/gpu_info_collector_linux.cc:262: while (it + 2 != pieces.rend()) {
On 2016/07/21 23:54:54, Ken Russell wrote:
> This looks risky. Please do something else which is more resilient to
> out-of-bounds accesses. Perhaps 
> 
>   while (pieces.rend() - it > 2) {
>   }

Done.

[Julien Isorce Samsung, 2016-07-22 07:44:06]

Description was changed from

==========
Omit '(Core Profile)' from GpuInfo.gl_version in CollectDriverInfoGL

This allow to select entries from kGpuDriverBugListJson
that relies on "driver_vendor": "Mesa" .
Previously there were not selected if gl version
contains the '(Core Profile)' string.

This allow to properly extract driver version and driver
vendor from a gl version that contains the '(Core Profile)' string.

Example: 
"3.3 (Core Profile) Mesa 10.5.9"

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
==========

to

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
==========

[Julien Isorce Samsung, 2016-07-22 07:44:24]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 07:44:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 08:04:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 08:04:33]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Julien Isorce Samsung, 2016-07-22 10:21:11]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 10:21:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 12:19:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 12:19:35]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2016-07-25 16:08:14]

lgtm

https://codereview.chromium.org/2153373002/diff/140001/gpu/config/gpu_info_co...
File gpu/config/gpu_info_collector_linux.cc (right):

https://codereview.chromium.org/2153373002/diff/140001/gpu/config/gpu_info_co...
gpu/config/gpu_info_collector_linux.cc:265: bool parsed =
re2::RE2::FullMatch(*it, "([\\d]+\\.[\\d]+(\\.[\\d]+)?).*",
Can you please see if there is a way using the re2 APIs to precompile this
regexp outside the inner loop?

[Julien Isorce Samsung, 2016-07-26 12:44:08]

https://codereview.chromium.org/2153373002/diff/140001/gpu/config/gpu_info_co...
File gpu/config/gpu_info_collector_linux.cc (right):

https://codereview.chromium.org/2153373002/diff/140001/gpu/config/gpu_info_co...
gpu/config/gpu_info_collector_linux.cc:265: bool parsed =
re2::RE2::FullMatch(*it, "([\\d]+\\.[\\d]+(\\.[\\d]+)?).*",
On 2016/07/25 16:08:14, Ken Russell OOO till 8-1-2016 wrote:
> Can you please see if there is a way using the re2 APIs to precompile this
> regexp outside the inner loop?

Thx for the suggestion. Indeed there is api to do that. Done in Patch Set 9.

[Julien Isorce Samsung, 2016-07-26 12:48:07]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 12:48:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 13:23:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 13:23:14]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-07-26 15:18:48]

The CQ bit was checked by j.isorce@samsung.com

[Julien Isorce Samsung, 2016-07-26 15:18:49]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2153373002/#ps160001
(title: "Rebase and precompile regexp")

[commit-bot: I haz the power, 2016-07-26 15:19:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 15:22:38]

Description was changed from

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
==========

to

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
==========

[commit-bot: I haz the power, 2016-07-26 15:22:40]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-26 15:24:42]

Description was changed from

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
==========

to

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Cr-Commit-Position: refs/heads/master@{#407804}
==========

[commit-bot: I haz the power, 2016-07-26 15:24:44]

Patchset 9 (id:??) landed as
https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Cr-Commit-Position: refs/heads/master@{#407804}

[Ken Russell (switch to Gerrit), 2016-07-27 17:55:12]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2182993004/ by kbr@chromium.org.

The reason for reverting is: Still breaks tests on Linux Intel:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N...
.

[Julien Isorce Samsung, 2016-07-28 22:09:56]

On 2016/07/27 17:55:12, Ken Russell OOO till 8-1-2016 wrote:
> A revert of this CL (patchset #9 id:160001) has been created in
> https://codereview.chromium.org/2182993004/ by mailto:kbr@chromium.org.
> 
> The reason for reverting is: Still breaks tests on Linux Intel:
>
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N...
> .

One of the error was due to https://codereview.chromium.org/2180763002 which
wrongly
updated the test. Indeed DriverBugWorkaroundsUponGLRendererPage is about testing
"gl_renderer" fields from kGpuDriverBugListJson.

The second error was due to the fact that "driver_vendor" should not be
considered
as "NeedsMoreInfo", so I added ".*" entry 173 ("disable_transparent_visuals").

[Julien Isorce Samsung, 2016-07-28 22:10:20]

Description was changed from

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Cr-Commit-Position: refs/heads/master@{#407804}
==========

to

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Cr-Commit-Position: refs/heads/master@{#407804}
==========

[Julien Isorce Samsung, 2016-07-28 22:10:28]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 22:10:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 23:13:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 23:13:28]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-07-29 05:39:10]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 05:39:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 07:32:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 07:32:05]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-07-29 08:09:22]

The CQ bit was checked by j.isorce@samsung.com

[Julien Isorce Samsung, 2016-07-29 08:09:22]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2153373002/#ps200001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-29 08:09:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 08:15:25]

Description was changed from

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Cr-Commit-Position: refs/heads/master@{#407804}
==========

to

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Cr-Commit-Position: refs/heads/master@{#407804}
==========

[commit-bot: I haz the power, 2016-07-29 08:15:26]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-07-29 08:17:30]

Description was changed from

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Cr-Commit-Position: refs/heads/master@{#407804}
==========

to

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
Cr-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Commit-Position: refs/heads/master@{#408604}
==========

[commit-bot: I haz the power, 2016-07-29 08:17:32]

Patchset 11 (id:??) landed as
https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
Cr-Commit-Position: refs/heads/master@{#408604}

[Corentin Wallez, 2016-08-01 19:51:52]

A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/2198243002/ by cwallez@chromium.org.

The reason for reverting is:
https://bugs.chromium.org/p/chromium/issues/detail?id=633286.

[Julien Isorce Samsung, 2016-08-01 20:55:55]

Description was changed from

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
Cr-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Commit-Position: refs/heads/master@{#408604}
==========

to

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
Cr-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Commit-Position: refs/heads/master@{#408604}
==========

[Julien Isorce Samsung, 2016-08-01 21:01:05]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 21:01:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 22:04:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:04:43]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Julien Isorce Samsung, 2016-08-02 16:18:16]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 16:18:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 18:06:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 18:06:56]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2016-08-02 20:33:49]

https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_...
gpu/config/gpu_driver_bug_list_json.cc:1845: "driver_vendor": ".*",
Is this really necessary, and if so why? It's the first instance in this file
which would use a regexp to match all driver vendors.

[Ken Russell (switch to Gerrit), 2016-08-02 20:34:21]

FWIW, I think you'll have to rebase again since I had to revert
https://codereview.chromium.org/2203713003/ .

[patyag0814, 2016-08-02 20:37:41]

Puto
El 2 ago. 2016 1:33 PM, <kbr@chromium.org> escribió:

>
>
>
https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_...
> File gpu/config/gpu_driver_bug_list_json.cc (right):
>
>
>
https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_...
> gpu/config/gpu_driver_bug_list_json.cc:1845: "driver_vendor": ".*",
> Is this really necessary, and if so why? It's the first instance in this
> file which would use a regexp to match all driver vendors.
>
> https://codereview.chromium.org/2153373002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Julien Isorce Samsung, 2016-08-02 23:37:54]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 23:38:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julien Isorce Samsung, 2016-08-02 23:47:41]

https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_...
gpu/config/gpu_driver_bug_list_json.cc:1845: "driver_vendor": ".*",
On 2016/08/02 20:33:49, Ken Russell wrote:
> Is this really necessary, and if so why? It's the first instance in this file
> which would use a regexp to match all driver vendors.

It is to avoid a nasty bug. I should find a proper way. The explanation is that
all gpu driver bug workarounds that are applied in browser process will always
be applied in the gpu process. Whereas after updating gl_renderer for example,
some workarounds might disappear since they can hit an exception from
kGpuDriverBugListJson. 
Without this change this CL it will not pass the Linux Intel builder since this
builder has 'Core Profile' in its gl version so it will hit that exception
bellow and fails as explained above.
I need to think about it.

[Julien Isorce Samsung, 2016-08-02 23:49:51]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 23:50:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julien Isorce Samsung, 2016-08-02 23:52:43]

On 2016/08/01 19:51:52, Corentin Wallez wrote:
> The reason for reverting is:
> https://bugs.chromium.org/p/chromium/issues/detail?id=633286.

Hi Corentin, I have included your test and I have include more fields to catch
the regression that was spotted by the Linux ATI bot. Please review it (Patch
Set 14), thx.

[commit-bot: I haz the power, 2016-08-03 01:52:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 01:52:07]

Dry run: This issue passed the CQ dry run.

[Corentin Wallez, 2016-08-03 14:38:14]

On 2016/08/02 at 23:52:43, j.isorce wrote:
> On 2016/08/01 19:51:52, Corentin Wallez wrote:
> > The reason for reverting is:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=633286.
> 
> Hi Corentin, I have included your test and I have include more fields to catch
> the regression that was spotted by the Linux ATI bot. Please review it (Patch
Set 14), thx.

Hey Julien, changes to the unittest LGTM as does the rest of the CL. I'm not an
owner though. Thanks for sticking through the countless reverts this CL got!

[Ken Russell (switch to Gerrit), 2016-08-03 19:18:51]

LGTM based on Corentin's re-review. Thanks for persisting with this patch, and
hoping this time's the charm.

[Julien Isorce Samsung, 2016-08-04 09:43:48]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 09:44:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julien Isorce Samsung, 2016-08-04 09:52:49]

On 2016/07/28 22:09:56, Julien Isorce wrote:
> On 2016/07/27 17:55:12, Ken Russell OOO till 8-1-2016 wrote:
> > A revert of this CL (patchset #9 id:160001) has been created in
> > https://codereview.chromium.org/2182993004/ by mailto:kbr@chromium.org.
> > 
> > The reason for reverting is: Still breaks tests on Linux Intel:
> >
>
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N...
> > .
> 
> The second error was due to the fact that "driver_vendor" should not be
> considered
> as "NeedsMoreInfo", so I added ".*" entry 173 ("disable_transparent_visuals").

>
https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_...
> gpu/config/gpu_driver_bug_list_json.cc:1845: "driver_vendor": ".*",
> On 2016/08/02 20:33:49, Ken Russell wrote:
> > Is this really necessary, and if so why? It's the first instance in this
file
> > which would use a regexp to match all driver vendors.
> 
> It is to avoid a nasty bug. I should find a proper way. The explanation is
that
> all gpu driver bug workarounds that are applied in browser process will always
> be applied in the gpu process. Whereas after updating gl_renderer for example,
> some workarounds might disappear since they can hit an exception from
> kGpuDriverBugListJson. 
> Without this change this CL it will not pass the Linux Intel builder since
this
> builder has 'Core Profile' in its gl version so it will hit that exception
> bellow and fails as explained above.
> I need to think about it.

There is a corner case when the glstrings cache is empty. In Patch Set 16
I included a fix for that with a comment. I think it is better solution
than adding "driver_vendor": ".*" in gpu_driver_bug_list_json.cc.


On 2016/08/03 14:38:14, Corentin Wallez wrote:
> Hey Julien, changes to the unittest LGTM as does the rest of the CL. I'm not
an
> owner though. Thanks for sticking through the countless reverts this CL got!
On 2016/08/03 19:18:51, Ken Russell wrote:
> LGTM based on Corentin's re-review. Thanks for persisting with this patch, and
> hoping this time's the charm.

Thx for the reviews. If it passes the CQ I will submit it and will check
all bots from https://build.chromium.org/p/chromium.gpu.fyi/builders/
more carefully.

[commit-bot: I haz the power, 2016-08-04 11:12:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 11:12:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Julien Isorce Samsung, 2016-08-04 12:21:06]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 12:21:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 13:44:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 13:44:39]

Dry run: This issue passed the CQ dry run.

[Corentin Wallez, 2016-08-04 13:46:24]

On 2016/08/04 at 09:52:49, j.isorce wrote:
> On 2016/07/28 22:09:56, Julien Isorce wrote:
> > On 2016/07/27 17:55:12, Ken Russell OOO till 8-1-2016 wrote:
> > > A revert of this CL (patchset #9 id:160001) has been created in
> > > https://codereview.chromium.org/2182993004/ by mailto:kbr@chromium.org.
> > > 
> > > The reason for reverting is: Still breaks tests on Linux Intel:
> > >
> >
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N...
> > > .
> > 
> > The second error was due to the fact that "driver_vendor" should not be
> > considered
> > as "NeedsMoreInfo", so I added ".*" entry 173
("disable_transparent_visuals").
> 
> >
https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_...
> > gpu/config/gpu_driver_bug_list_json.cc:1845: "driver_vendor": ".*",
> > On 2016/08/02 20:33:49, Ken Russell wrote:
> > > Is this really necessary, and if so why? It's the first instance in this
file
> > > which would use a regexp to match all driver vendors.
> > 
> > It is to avoid a nasty bug. I should find a proper way. The explanation is
that
> > all gpu driver bug workarounds that are applied in browser process will
always
> > be applied in the gpu process. Whereas after updating gl_renderer for
example,
> > some workarounds might disappear since they can hit an exception from
> > kGpuDriverBugListJson. 
> > Without this change this CL it will not pass the Linux Intel builder since
this
> > builder has 'Core Profile' in its gl version so it will hit that exception
> > bellow and fails as explained above.
> > I need to think about it.
> 
> There is a corner case when the glstrings cache is empty. In Patch Set 16
> I included a fix for that with a comment. I think it is better solution
> than adding "driver_vendor": ".*" in gpu_driver_bug_list_json.cc.
> 
> 
> On 2016/08/03 14:38:14, Corentin Wallez wrote:
> > Hey Julien, changes to the unittest LGTM as does the rest of the CL. I'm not
an
> > owner though. Thanks for sticking through the countless reverts this CL got!
> On 2016/08/03 19:18:51, Ken Russell wrote:
> > LGTM based on Corentin's re-review. Thanks for persisting with this patch,
and
> > hoping this time's the charm.
> 
> Thx for the reviews. If it passes the CQ I will submit it and will check
> all bots from https://build.chromium.org/p/chromium.gpu.fyi/builders/
> more carefully.

Still LGTM. It is sad that this ChooseVisualForWindow business forces us to pass
data through flags.

[Julien Isorce Samsung, 2016-08-04 13:46:27]

The CQ bit was checked by j.isorce@samsung.com

[Julien Isorce Samsung, 2016-08-04 13:46:27]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2153373002/#ps320001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-04 13:46:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 13:53:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 13:53:54]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Julien Isorce Samsung, 2016-08-04 13:58:17]

On 2016/08/04 13:53:54, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/browser/browser_main_loop.cc

Hi Antoine, please have a look. Thx. (my previous comment contains explanation
for it)

[Julien Isorce Samsung, 2016-08-09 16:09:09]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 16:09:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 18:20:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 18:20:58]

Dry run: This issue passed the CQ dry run.

[piman, 2016-08-11 05:05:50]

lgtm

[Julien Isorce Samsung, 2016-08-11 17:16:28]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 17:16:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 17:37:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:37:01]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Julien Isorce Samsung, 2016-08-11 19:10:09]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 19:10:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 21:40:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 21:40:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Julien Isorce Samsung, 2016-08-11 22:09:00]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 22:10:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 00:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 00:42:19]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-08-12 07:08:59]

The CQ bit was checked by j.isorce@samsung.com

[Julien Isorce Samsung, 2016-08-12 07:08:59]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org, cwallez@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2153373002/#ps380001
(title: "Just rebase")

[commit-bot: I haz the power, 2016-08-12 07:09:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 07:16:44]

Description was changed from

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
Cr-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Commit-Position: refs/heads/master@{#408604}
==========

to

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
Cr-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Commit-Position: refs/heads/master@{#408604}
==========

[commit-bot: I haz the power, 2016-08-12 07:16:46]

Committed patchset #20 (id:380001)

[commit-bot: I haz the power, 2016-08-12 07:18:54]

Description was changed from

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
Cr-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Commit-Position: refs/heads/master@{#408604}
==========

to

==========
On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG=628929

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
Committed: https://crrev.com/84e4f0e4b82370e00bfc07cb05c489783b219bee
Cr-Original-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Original-Commit-Position: refs/heads/master@{#408604}
Cr-Commit-Position: refs/heads/master@{#411568}
==========

[commit-bot: I haz the power, 2016-08-12 07:18:56]

Patchset 20 (id:??) landed as
https://crrev.com/84e4f0e4b82370e00bfc07cb05c489783b219bee
Cr-Commit-Position: refs/heads/master@{#411568}