Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2153373002: On Linux rework driver_version/vendor extraction from gl version (Closed)

Created:
4 years, 5 months ago by Julien Isorce Samsung
Modified:
4 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

On Linux rework driver_version/vendor extraction from gl version Previously it could not extract them from the gl version "3.3 (Core Profile) Mesa 10.5.9" because of the presence of '(Core Profile)'. BUG=628929 R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL* Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358 Committed: https://crrev.com/84e4f0e4b82370e00bfc07cb05c489783b219bee Cr-Original-Original-Commit-Position: refs/heads/master@{#407804} Cr-Original-Commit-Position: refs/heads/master@{#408604} Cr-Commit-Position: refs/heads/master@{#411568}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase and fix erroneous condition #

Patch Set 5 : Rebase and add unit test #

Total comments: 3

Patch Set 6 : Make it generic #

Total comments: 4

Patch Set 7 : Rebase and use regex #

Patch Set 8 : forgot a plus #

Total comments: 2

Patch Set 9 : Rebase and precompile regexp #

Patch Set 10 : Rebase and fix tests #

Patch Set 11 : Rebase #

Patch Set 12 : Rebase and only extract from gl_version if cannot use specifics #

Total comments: 2

Patch Set 13 : Rebase and fixed remaining failure #

Patch Set 14 : Rebase and add unit test to catch regression on Linux ATI builder #

Patch Set 15 : Fix build error on Android #

Patch Set 16 : Rebase and make --disable_transparent_visuals persistent once used. #

Patch Set 17 : Rebase #

Patch Set 18 : Rebase #

Patch Set 19 : Just rebase #

Patch Set 20 : Just rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -32 lines) Patch
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +8 lines, -0 lines 0 comments Download
M content/test/gpu/page_sets/gpu_process_tests.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +5 lines, -6 lines 0 comments Download
M gpu/config/gpu_info_collector_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +25 lines, -8 lines 0 comments Download
M gpu/config/gpu_info_collector_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +89 lines, -18 lines 0 comments Download

Messages

Total messages: 167 (121 generated)
patyag0814
4 years, 5 months ago (2016-07-17 17:09:37 UTC) #7
patyag0814
4 years, 5 months ago (2016-07-17 17:09:38 UTC) #8
patyag0814
4 years, 5 months ago (2016-07-17 17:12:34 UTC) #9
patyag0814
4 years, 5 months ago (2016-07-17 17:12:36 UTC) #10
patyag0814
4 years, 5 months ago (2016-07-17 17:12:49 UTC) #11
patyag0814
4 years, 5 months ago (2016-07-17 17:12:52 UTC) #12
patyag0814
4 years, 5 months ago (2016-07-17 17:12:54 UTC) #13
Zhenyao Mo
On 2016/07/17 17:12:54, patyag0814 wrote: We should fix the driver version extraction code to be ...
4 years, 5 months ago (2016-07-17 17:37:53 UTC) #14
Ken Russell (switch to Gerrit)
On 2016/07/17 17:37:53, Zhenyao Mo wrote: > On 2016/07/17 17:12:54, patyag0814 wrote: > > We ...
4 years, 5 months ago (2016-07-18 18:45:24 UTC) #31
Julien Isorce Samsung
On 2016/07/18 18:45:24, Ken Russell wrote: > On 2016/07/17 17:37:53, Zhenyao Mo wrote: > > ...
4 years, 5 months ago (2016-07-19 09:11:27 UTC) #32
Julien Isorce Samsung
Hi, I fixed the CL but I plan to add a unit test for it, ...
4 years, 5 months ago (2016-07-20 21:53:16 UTC) #47
Ken Russell (switch to Gerrit)
On 2016/07/20 21:53:16, Julien Isorce wrote: > Hi, I fixed the CL but I plan ...
4 years, 5 months ago (2016-07-20 23:59:29 UTC) #48
Julien Isorce Samsung
On 2016/07/20 23:59:29, Ken Russell wrote: > On 2016/07/20 21:53:16, Julien Isorce wrote: > > ...
4 years, 5 months ago (2016-07-21 08:03:20 UTC) #50
Zhenyao Mo
lgtm https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_collector_linux.cc File gpu/config/gpu_info_collector_linux.cc (right): https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_collector_linux.cc#newcode253 gpu/config/gpu_info_collector_linux.cc:253: std::string core_profile = "(Core Profile)"; I guess this ...
4 years, 5 months ago (2016-07-21 13:30:44 UTC) #55
Julien Isorce Samsung
https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_collector_linux.cc File gpu/config/gpu_info_collector_linux.cc (right): https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_collector_linux.cc#newcode253 gpu/config/gpu_info_collector_linux.cc:253: std::string core_profile = "(Core Profile)"; On 2016/07/21 13:30:44, Zhenyao ...
4 years, 5 months ago (2016-07-21 13:56:37 UTC) #56
Zhenyao Mo
https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_collector_linux.cc File gpu/config/gpu_info_collector_linux.cc (right): https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_collector_linux.cc#newcode253 gpu/config/gpu_info_collector_linux.cc:253: std::string core_profile = "(Core Profile)"; On 2016/07/21 13:56:36, Julien ...
4 years, 5 months ago (2016-07-21 13:59:47 UTC) #57
Julien Isorce Samsung
On 2016/07/21 13:59:47, Zhenyao Mo wrote: > https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_collector_linux.cc > File gpu/config/gpu_info_collector_linux.cc (right): > > https://codereview.chromium.org/2153373002/diff/80001/gpu/config/gpu_info_collector_linux.cc#newcode253 ...
4 years, 5 months ago (2016-07-21 23:18:04 UTC) #60
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/2153373002/diff/100001/gpu/config/gpu_info_collector_linux.cc File gpu/config/gpu_info_collector_linux.cc (right): https://codereview.chromium.org/2153373002/diff/100001/gpu/config/gpu_info_collector_linux.cc#newcode258 gpu/config/gpu_info_collector_linux.cc:258: // Search from the end for the first piece ...
4 years, 5 months ago (2016-07-21 23:54:55 UTC) #61
Julien Isorce Samsung
Thx for the suggestions, I uploaded new patch set, please have a look, thx. https://codereview.chromium.org/2153373002/diff/100001/gpu/config/gpu_info_collector_linux.cc ...
4 years, 5 months ago (2016-07-22 07:38:29 UTC) #64
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/2153373002/diff/140001/gpu/config/gpu_info_collector_linux.cc File gpu/config/gpu_info_collector_linux.cc (right): https://codereview.chromium.org/2153373002/diff/140001/gpu/config/gpu_info_collector_linux.cc#newcode265 gpu/config/gpu_info_collector_linux.cc:265: bool parsed = re2::RE2::FullMatch(*it, "([\\d]+\\.[\\d]+(\\.[\\d]+)?).*", Can you please ...
4 years, 5 months ago (2016-07-25 16:08:14 UTC) #74
Julien Isorce Samsung
https://codereview.chromium.org/2153373002/diff/140001/gpu/config/gpu_info_collector_linux.cc File gpu/config/gpu_info_collector_linux.cc (right): https://codereview.chromium.org/2153373002/diff/140001/gpu/config/gpu_info_collector_linux.cc#newcode265 gpu/config/gpu_info_collector_linux.cc:265: bool parsed = re2::RE2::FullMatch(*it, "([\\d]+\\.[\\d]+(\\.[\\d]+)?).*", On 2016/07/25 16:08:14, Ken ...
4 years, 4 months ago (2016-07-26 12:44:08 UTC) #75
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153373002/160001
4 years, 4 months ago (2016-07-26 15:19:06 UTC) #82
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 4 months ago (2016-07-26 15:22:40 UTC) #84
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd Cr-Commit-Position: refs/heads/master@{#407804}
4 years, 4 months ago (2016-07-26 15:24:44 UTC) #86
Ken Russell (switch to Gerrit)
A revert of this CL (patchset #9 id:160001) has been created in https://codereview.chromium.org/2182993004/ by kbr@chromium.org. ...
4 years, 4 months ago (2016-07-27 17:55:12 UTC) #87
Julien Isorce Samsung
On 2016/07/27 17:55:12, Ken Russell OOO till 8-1-2016 wrote: > A revert of this CL ...
4 years, 4 months ago (2016-07-28 22:09:56 UTC) #88
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153373002/200001
4 years, 4 months ago (2016-07-29 08:09:40 UTC) #100
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 4 months ago (2016-07-29 08:15:26 UTC) #102
commit-bot: I haz the power
Patchset 11 (id:??) landed as https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358 Cr-Commit-Position: refs/heads/master@{#408604}
4 years, 4 months ago (2016-07-29 08:17:32 UTC) #104
Corentin Wallez
A revert of this CL (patchset #11 id:200001) has been created in https://codereview.chromium.org/2198243002/ by cwallez@chromium.org. ...
4 years, 4 months ago (2016-08-01 19:51:52 UTC) #105
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_bug_list_json.cc#newcode1845 gpu/config/gpu_driver_bug_list_json.cc:1845: "driver_vendor": ".*", Is this really necessary, and if so ...
4 years, 4 months ago (2016-08-02 20:33:49 UTC) #115
Ken Russell (switch to Gerrit)
FWIW, I think you'll have to rebase again since I had to revert https://codereview.chromium.org/2203713003/ .
4 years, 4 months ago (2016-08-02 20:34:21 UTC) #116
patyag0814
Puto El 2 ago. 2016 1:33 PM, <kbr@chromium.org> escribió: > > > https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_bug_list_json.cc > File ...
4 years, 4 months ago (2016-08-02 20:37:41 UTC) #117
Julien Isorce Samsung
https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2153373002/diff/220001/gpu/config/gpu_driver_bug_list_json.cc#newcode1845 gpu/config/gpu_driver_bug_list_json.cc:1845: "driver_vendor": ".*", On 2016/08/02 20:33:49, Ken Russell wrote: > ...
4 years, 4 months ago (2016-08-02 23:47:41 UTC) #120
Julien Isorce Samsung
On 2016/08/01 19:51:52, Corentin Wallez wrote: > The reason for reverting is: > https://bugs.chromium.org/p/chromium/issues/detail?id=633286. Hi ...
4 years, 4 months ago (2016-08-02 23:52:43 UTC) #123
Corentin Wallez
On 2016/08/02 at 23:52:43, j.isorce wrote: > On 2016/08/01 19:51:52, Corentin Wallez wrote: > > ...
4 years, 4 months ago (2016-08-03 14:38:14 UTC) #126
Ken Russell (switch to Gerrit)
LGTM based on Corentin's re-review. Thanks for persisting with this patch, and hoping this time's ...
4 years, 4 months ago (2016-08-03 19:18:51 UTC) #127
Julien Isorce Samsung
On 2016/07/28 22:09:56, Julien Isorce wrote: > On 2016/07/27 17:55:12, Ken Russell OOO till 8-1-2016 ...
4 years, 4 months ago (2016-08-04 09:52:49 UTC) #130
Corentin Wallez
On 2016/08/04 at 09:52:49, j.isorce wrote: > On 2016/07/28 22:09:56, Julien Isorce wrote: > > ...
4 years, 4 months ago (2016-08-04 13:46:24 UTC) #137
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153373002/320001
4 years, 4 months ago (2016-08-04 13:46:45 UTC) #140
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/231062)
4 years, 4 months ago (2016-08-04 13:53:54 UTC) #142
Julien Isorce Samsung
On 2016/08/04 13:53:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-04 13:58:17 UTC) #143
piman
lgtm
4 years, 4 months ago (2016-08-11 05:05:50 UTC) #148
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153373002/380001
4 years, 4 months ago (2016-08-12 07:09:19 UTC) #163
commit-bot: I haz the power
Committed patchset #20 (id:380001)
4 years, 4 months ago (2016-08-12 07:16:46 UTC) #165
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 07:18:56 UTC) #167
Message was sent while issue was closed.
Patchset 20 (id:??) landed as
https://crrev.com/84e4f0e4b82370e00bfc07cb05c489783b219bee
Cr-Commit-Position: refs/heads/master@{#411568}

Powered by Google App Engine
This is Rietveld 408576698