Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2180763002: gpu: Remove disable_multisampled_render_to_texture (Closed)

Created:
4 years, 5 months ago by boliu
Modified:
4 years, 5 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Remove disable_multisampled_render_to_texture Disable the extension instead. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6548697db9753a1633080d6e6cbbe296bf32b493 Cr-Commit-Position: refs/heads/master@{#407515}

Patch Set 1 #

Patch Set 2 : fix test maybe #

Total comments: 2

Patch Set 3 : bump version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M content/test/gpu/page_sets/gpu_process_tests.py View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +13 lines, -15 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
boliu
ptal
4 years, 5 months ago (2016-07-25 15:38:41 UTC) #11
no sievers
lgtm thanks! https://codereview.chromium.org/2180763002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2180763002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.78", nit: still bump the version ...
4 years, 5 months ago (2016-07-25 17:18:20 UTC) #12
boliu
https://codereview.chromium.org/2180763002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2180763002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.78", On 2016/07/25 17:18:20, sievers wrote: > nit: ...
4 years, 5 months ago (2016-07-25 17:20:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180763002/40001
4 years, 5 months ago (2016-07-25 17:21:16 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-25 18:11:36 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 18:14:58 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6548697db9753a1633080d6e6cbbe296bf32b493
Cr-Commit-Position: refs/heads/master@{#407515}

Powered by Google App Engine
This is Rietveld 408576698