Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2203713003: Revert of Fix ineffective --disable-gpu-driver-bug-workarounds (Closed)

Created:
4 years, 4 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix ineffective --disable-gpu-driver-bug-workarounds (patchset #6 id:100001 of https://codereview.chromium.org/2195743005/ ) Reason for revert: New test causes assertion failures in the GPU process on Nexus 9 and possibly other devices. See https://bugs.chromium.org/p/chromium/issues/detail?id=359367#c3 . Original issue's description: > Fix ineffective --disable-gpu-driver-bug-workarounds > > It was hidden to the user since chrome://gpu was not showing > any workarounds, but they were still applied in the gpu process. > > Also add a gpu test that sets > --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing > and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND > in both browser and gpu processes. > > BUG=359367 > > R=kbr@chromium.org, zmo@chromium.org > > TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 > Cr-Commit-Position: refs/heads/master@{#409197} TBR=zmo@chromium.org,j.isorce@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=359367 Committed: https://crrev.com/1e01efbf52d8bf38d324e95216de90901a69d636 Cr-Commit-Position: refs/heads/master@{#409285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/gpu/page_sets/gpu_process_tests.py View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Russell (switch to Gerrit)
Created Revert of Fix ineffective --disable-gpu-driver-bug-workarounds
4 years, 4 months ago (2016-08-02 19:55:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203713003/1
4 years, 4 months ago (2016-08-02 19:56:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 19:56:55 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 19:59:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e01efbf52d8bf38d324e95216de90901a69d636
Cr-Commit-Position: refs/heads/master@{#409285}

Powered by Google App Engine
This is Rietveld 408576698