Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2198243002: Revert of On Linux rework driver_version/vendor extraction from gl version (Closed)

Created:
4 years, 4 months ago by Corentin Wallez
Modified:
4 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of On Linux rework driver_version/vendor extraction from gl version (patchset #11 id:200001 of https://codereview.chromium.org/2153373002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=633286 Original issue's description: > On Linux rework driver_version/vendor extraction from gl version > > Previously it could not extract them from the gl version > "3.3 (Core Profile) Mesa 10.5.9" because of the presence > of '(Core Profile)'. > > BUG=628929 > > R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL* > > Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd > Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358 > Cr-Original-Commit-Position: refs/heads/master@{#407804} > Cr-Commit-Position: refs/heads/master@{#408604} TBR=kbr@chromium.org,piman@chromium.org,zmo@chromium.org,patyag0814@gmail.com,j.isorce@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628929 Committed: https://crrev.com/f1c7fb66c2edd6be58a8bb5e1b67d679e2b44dfc Cr-Commit-Position: refs/heads/master@{#409049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -32 lines) Patch
M content/test/gpu/page_sets/gpu_process_tests.py View 2 chunks +5 lines, -4 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +1 line, -2 lines 0 comments Download
M gpu/config/gpu_info_collector_linux.cc View 3 chunks +10 lines, -18 lines 0 comments Download
M gpu/config/gpu_info_collector_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Corentin Wallez
Created Revert of On Linux rework driver_version/vendor extraction from gl version
4 years, 4 months ago (2016-08-01 19:51:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198243002/1
4 years, 4 months ago (2016-08-01 19:52:18 UTC) #3
Ken Russell (switch to Gerrit)
LGTM. Thanks for tracking this down Corentin and in particular for adding a unit test ...
4 years, 4 months ago (2016-08-01 20:17:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 20:50:06 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 20:54:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1c7fb66c2edd6be58a8bb5e1b67d679e2b44dfc
Cr-Commit-Position: refs/heads/master@{#409049}

Powered by Google App Engine
This is Rietveld 408576698