Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2182993004: Revert of On Linux rework driver_version/vendor extraction from gl version (Closed)

Created:
4 years, 4 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of On Linux rework driver_version/vendor extraction from gl version (patchset #9 id:160001 of https://codereview.chromium.org/2153373002/ ) Reason for revert: Still breaks tests on Linux Intel: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28New%20Intel%29/builds/2661 Original issue's description: > On Linux rework driver_version/vendor extraction from gl version > > Previously it could not extract them from the gl version > "3.3 (Core Profile) Mesa 10.5.9" because of the presence > of '(Core Profile)'. > > BUG=628929 > > R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL* > > Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd > Cr-Commit-Position: refs/heads/master@{#407804} TBR=piman@chromium.org,zmo@chromium.org,patyag0814@gmail.com,cwallez@chromium.org,j.isorce@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628929 Committed: https://crrev.com/7cebbdfb442249d56a3567444ee71ce256863f35 Cr-Commit-Position: refs/heads/master@{#408198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -26 lines) Patch
M gpu/config/gpu_info_collector_linux.cc View 3 chunks +10 lines, -18 lines 0 comments Download
M gpu/config/gpu_info_collector_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Russell (switch to Gerrit)
Created Revert of On Linux rework driver_version/vendor extraction from gl version
4 years, 4 months ago (2016-07-27 17:55:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182993004/1
4 years, 4 months ago (2016-07-27 17:55:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 18:37:24 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 18:39:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cebbdfb442249d56a3567444ee71ce256863f35
Cr-Commit-Position: refs/heads/master@{#408198}

Powered by Google App Engine
This is Rietveld 408576698