recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds.

recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds.

This isn't necessary: Both in gyp and gn builds, the .gyp and .gn files that
add the precompiled header flags know to only do this if goma isn't enabled.
This has to be done in gyp / gn files, so that if devs enable goma they only
need to set use_goma=true and don't have to set this other flag as well. So
rely on this in the recipe too.  (What the recipe does only has an effect in
gyp builds anyways, and gyp's going away.  And even then, it only has an effect
on bots not using mb, while virtually all bots should be on mb by now.)

BUG=none, but it's preparation for 627903

Committed: https://chromium.googlesource.com/chromium/tools/build/+/3f24026c9a55f730df9c8de024f8c112e3b1c21e

[Nico, 2016-07-13 18:31:39]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org

[Nico, 2016-07-13 18:31:41]

https://codereview.chromium.org/2151583002/diff/1/scripts/slave/recipes/win_a...
File
scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json
(right):

https://codereview.chromium.org/2151583002/diff/1/scripts/slave/recipes/win_a...
scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json:137:
"GYP_DEFINES": "component=shared_library fastbuild=2 gomadir='[BUILD]\\goma'
target_arch=ia32 use_goma=0 win_analyze=1",
This diff is a bit surprising since this passes use_goma=0 and still loses the
flag. This is because
https://cs.chromium.org/chromium/build/scripts/slave/recipes/win_analyze.py?r...
does strange things. Since the bot is on mb, this doesn't have an effect though.

[Dirk Pranke, 2016-07-13 19:09:45]

lgtm

[Nico, 2016-07-13 19:10:16]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-07-13 19:10:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:16:25]

Description was changed from

==========
recipes/win: Stop explicitly disabling precompiled headers in recipes in goma
builds.

This isn't necessary: Both in gyp and gn builds, the .gyp and .gn files that
add the precompiled header flags know to only do this if goma isn't enabled.
This has to be done in gyp / gn files, so that if devs enable goma they only
need to set use_goma=true and don't have to set this other flag as well. So
rely on this in the recipe too.  (What the recipe does only has an effect in
gyp builds anyways, and gyp's going away.  And even then, it only has an effect
on bots not using mb, while virtually all bots should be on mb by now.)

BUG=none, but it's preparation for 627903
==========

to

==========
recipes/win: Stop explicitly disabling precompiled headers in recipes in goma
builds.

This isn't necessary: Both in gyp and gn builds, the .gyp and .gn files that
add the precompiled header flags know to only do this if goma isn't enabled.
This has to be done in gyp / gn files, so that if devs enable goma they only
need to set use_goma=true and don't have to set this other flag as well. So
rely on this in the recipe too.  (What the recipe does only has an effect in
gyp builds anyways, and gyp's going away.  And even then, it only has an effect
on bots not using mb, while virtually all bots should be on mb by now.)

BUG=none, but it's preparation for 627903

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/3f24026c9a55f730df9c...
==========

[commit-bot: I haz the power, 2016-07-13 19:16:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/3f24026c9a55f730df9c...