scripts/slave/recipes/chromium.expected/full_chromium_Win.json - Issue 2151583002: recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds.

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_Win.json

Issue 2151583002: recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json » ('j') | scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_Win.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_Win.json b/scripts/slave/recipes/chromium.expected/full_chromium_Win.json

index 62c7db25f76cf322f96d933430bd924f54ec79a2..15497e969b97c140ab85a94898dc06ec4e9540f8 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_Win.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_Win.json

@@ -219,7 +219,7 @@

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json",

"GYP_CHROMIUM_NO_ACTION": "1",

- "GYP_DEFINES": "chromium_win_pch=0 component=static_library fastbuild=1 gomadir='[CACHE]\\cipd\\goma' linux_dump_symbols=0 target_arch=ia32 test_isolation_mode=noop use_goma=1",

+ "GYP_DEFINES": "component=static_library fastbuild=1 gomadir='[CACHE]\\cipd\\goma' linux_dump_symbols=0 target_arch=ia32 test_isolation_mode=noop use_goma=1",

"PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"

"name": "gclient runhooks"

@@ -343,7 +343,7 @@

"--target",

"Release",

"--factory-properties",

- "{\"gclient_env\": {\"GYP_DEFINES\": \"chromium_win_pch=0 component=static_library fastbuild=1 gomadir='[CACHE]\\\\cipd\\\\goma' linux_dump_symbols=0 target_arch=ia32 test_isolation_mode=noop use_goma=1\"}, \"gs_acl\": \"public-read\", \"gs_bucket\": \"gs://chromium-browser-snapshots\"}",

+ "{\"gclient_env\": {\"GYP_DEFINES\": \"component=static_library fastbuild=1 gomadir='[CACHE]\\\\cipd\\\\goma' linux_dump_symbols=0 target_arch=ia32 test_isolation_mode=noop use_goma=1\"}, \"gs_acl\": \"public-read\", \"gs_bucket\": \"gs://chromium-browser-snapshots\"}",

"--build-properties",

"{\"got_angle_revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\", \"got_angle_revision_cp\": \"refs/heads/master@{#297276}\", \"got_buildtools_revision\": \"f0319a328b2809876916353cb994259692140934\", \"got_buildtools_revision_cp\": \"refs/heads/master@{#182578}\", \"got_nacl_revision\": \"d998e125e8253980d76e269b7982aeeefc1b9b50\", \"got_nacl_revision_cp\": \"refs/heads/master@{#274981}\", \"got_revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\", \"got_revision_cp\": \"refs/heads/master@{#170242}\", \"got_swarming_client_revision\": \"a0ee5d99f1d4b38ddaa4c759c837980b63b99566\", \"got_swarming_client_revision_cp\": \"refs/heads/master@{#276089}\", \"got_v8_revision\": \"801ada225ddc271c132c3a35f03975671d43e399\", \"got_v8_revision_cp\": \"refs/heads/master@{#43426}\", \"got_webrtc_revision\": \"0f90628433546e61d9268596da93418c623137f4\", \"got_webrtc_revision_cp\": \"refs/heads/master@{#120644}\"}",

"--mode",