Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 2151583002: recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import pipes 5 import pipes
6 6
7 from recipe_engine.config import config_item_context, ConfigGroup 7 from recipe_engine.config import config_item_context, ConfigGroup
8 from recipe_engine.config import Dict, List, Single, Static, Set, BadConf 8 from recipe_engine.config import Dict, List, Single, Static, Set, BadConf
9 from recipe_engine.config_types import Path 9 from recipe_engine.config_types import Path
10 10
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 raise BadConf('goma config doesn\'t understand %s' % c.compile_py.compiler) 304 raise BadConf('goma config doesn\'t understand %s' % c.compile_py.compiler)
305 305
306 c.gyp_env.GYP_DEFINES['use_goma'] = 1 306 c.gyp_env.GYP_DEFINES['use_goma'] = 1
307 307
308 goma_dir = c.BUILD_PATH.join('goma') 308 goma_dir = c.BUILD_PATH.join('goma')
309 c.gyp_env.GYP_DEFINES['gomadir'] = goma_dir 309 c.gyp_env.GYP_DEFINES['gomadir'] = goma_dir
310 c.compile_py.goma_dir = goma_dir 310 c.compile_py.goma_dir = goma_dir
311 311
312 if c.TARGET_PLATFORM == 'win' and c.compile_py.compiler != 'goma-clang': 312 if c.TARGET_PLATFORM == 'win' and c.compile_py.compiler != 'goma-clang':
313 fastbuild(c) 313 fastbuild(c)
314 pch(c, invert=True)
315
316 @config_ctx()
317 def pch(c, invert=False):
318 if c.TARGET_PLATFORM == 'win':
319 c.gyp_env.GYP_DEFINES['chromium_win_pch'] = int(not invert)
320 314
321 @config_ctx() 315 @config_ctx()
322 def dcheck(c, invert=False): 316 def dcheck(c, invert=False):
323 c.gyp_env.GYP_DEFINES['dcheck_always_on'] = int(not invert) 317 c.gyp_env.GYP_DEFINES['dcheck_always_on'] = int(not invert)
324 318
325 @config_ctx() 319 @config_ctx()
326 def fastbuild(c, invert=False): 320 def fastbuild(c, invert=False):
327 c.gyp_env.GYP_DEFINES['fastbuild'] = int(not invert) 321 c.gyp_env.GYP_DEFINES['fastbuild'] = int(not invert)
328 322
329 @config_ctx() 323 @config_ctx()
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
818 c.gyp_env.GYP_DEFINES['internal_gles2_conform_tests'] = 1 812 c.gyp_env.GYP_DEFINES['internal_gles2_conform_tests'] = 1
819 813
820 @config_ctx() 814 @config_ctx()
821 def build_angle_deqp_tests(c): 815 def build_angle_deqp_tests(c):
822 c.gyp_env.GYP_DEFINES['build_angle_deqp_tests'] = 1 816 c.gyp_env.GYP_DEFINES['build_angle_deqp_tests'] = 1
823 817
824 @config_ctx() 818 @config_ctx()
825 def force_mac_toolchain(c): 819 def force_mac_toolchain(c):
826 c.env.FORCE_MAC_TOOLCHAIN = 1 820 c.env.FORCE_MAC_TOOLCHAIN = 1
827 c.gyp_env.FORCE_MAC_TOOLCHAIN = 1 821 c.gyp_env.FORCE_MAC_TOOLCHAIN = 1
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698