scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json - Issue 2151583002: recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json

Issue 2151583002: recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___nosnap___shared.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___debug.json » ('j') | scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json

diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json

index 1101bba94e27e280bfa2f8b582c09f2b759ad12e..08883007b28016ec10c7ffa9d9c18699f819fc15 100644

--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json

+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json

@@ -150,7 +150,7 @@

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json",

"GYP_CHROMIUM_NO_ACTION": "1",

- "GYP_DEFINES": "chromium_win_pch=0 fastbuild=1 gomadir='[CACHE]\\cipd\\goma' target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64",

+ "GYP_DEFINES": "fastbuild=1 gomadir='[CACHE]\\cipd\\goma' target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64",

"GYP_GENERATORS": "ninja",

"GYP_MSVS_VERSION": "2013",

"PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"