scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Clang_Perf.json - Issue 2151583002: recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Clang_Perf.json

Issue 2151583002: recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_7_Intel_GPU_Perf__Xeon_.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Power_Perf__DELL_.json » ('j') | scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"	6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"

7 ],	7 ],

8 "name": "taskkill"	8 "name": "taskkill"

9 },	9 },

10 {	10 {

(...skipping 127 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
138 {	138 {

139 "cmd": [	139 "cmd": [

140 "python",	140 "python",

141 "-u",	141 "-u",

142 "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",	142 "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",

143 "runhooks"	143 "runhooks"

144 ],	144 ],

145 "cwd": "[BUILDER_CACHE]\\Win_Clang_Perf\\src",	145 "cwd": "[BUILDER_CACHE]\\Win_Clang_Perf\\src",

146 "env": {	146 "env": {

147 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json",	147 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json",

148 "GYP_DEFINES": "branding=Chrome buildtype=Official chromium_win_pch=0 comp onent=static_library fastbuild=1 gomadir='RECIPE_PACKAGE_REPO[build]\\goma' targ et_arch=ia32 use_goma=0",	148 "GYP_DEFINES": "branding=Chrome buildtype=Official component=static_librar y fastbuild=1 gomadir='RECIPE_PACKAGE_REPO[build]\\goma' target_arch=ia32 use_go ma=0",

149 "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"	149 "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"

150 },	150 },

151 "name": "gclient runhooks"	151 "name": "gclient runhooks"

152 },	152 },

153 {	153 {

154 "cmd": [	154 "cmd": [

155 "python",	155 "python",

156 "-u",	156 "-u",

157 "RECIPE_PACKAGE_REPO[build]\\scripts\\tools\\runit.py",	157 "RECIPE_PACKAGE_REPO[build]\\scripts\\tools\\runit.py",

158 "--show-path",	158 "--show-path",

(...skipping 296 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
455 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json"	455 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json"

456 },	456 },

457 "name": "process_dumps"	457 "name": "process_dumps"

458 },	458 },

459 {	459 {

460 "name": "$result",	460 "name": "$result",

461 "recipe_result": null,	461 "recipe_result": null,

462 "status_code": 0	462 "status_code": 0

463 }	463 }

464 ]	464 ]

OLD	NEW