Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h

Issue 2151273003: [DevTools] Move browser logging from Console domain to Log domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@internals-method
Patch Set: protocol improvements Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
index 90de26154b5988d121d02fde29205116a6401e71..923a84e92690808285b939989f944e3489655332 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
@@ -21,7 +21,7 @@ class V8DebuggerImpl;
class V8InspectorSessionImpl;
class V8StackTrace;
-enum class V8MessageOrigin { kExternalConsole, kConsole, kException, kRevokedException };
+enum class V8MessageOrigin { kConsole, kException, kRevokedException };
enum class ConsoleAPIType { kLog, kDebug, kInfo, kError, kWarning, kDir, kDirXML, kTable, kTrace, kStartGroup, kStartGroupCollapsed, kEndGroup, kClear, kAssert, kTimeEnd, kCount };
@@ -54,27 +54,14 @@ public:
const String16& message,
unsigned revokedExceptionId);
- static std::unique_ptr<V8ConsoleMessage> createExternal(
- double timestamp,
- MessageSource,
- MessageLevel,
- const String16& message,
- const String16& url,
- unsigned lineNumber,
- unsigned columnNumber,
- std::unique_ptr<V8StackTrace>,
- int scriptId,
- const String16& requestIdentifier,
- const String16& workerId);
-
V8MessageOrigin origin() const;
- void reportToFrontend(protocol::Console::Frontend*, V8InspectorSessionImpl*, bool generatePreview) const;
+ void reportToFrontend(protocol::Console::Frontend*) const;
void reportToFrontend(protocol::Runtime::Frontend*, V8InspectorSessionImpl*, bool generatePreview) const;
ConsoleAPIType type() const;
void contextDestroyed(int contextId);
private:
- V8ConsoleMessage(V8MessageOrigin, double timestamp, MessageSource, MessageLevel, const String16& message);
+ V8ConsoleMessage(V8MessageOrigin, double timestamp, const String16& message);
using Arguments = std::vector<std::unique_ptr<v8::Global<v8::Value>>>;
std::unique_ptr<protocol::Array<protocol::Runtime::RemoteObject>> wrapArguments(V8InspectorSessionImpl*, bool generatePreview) const;
@@ -83,16 +70,12 @@ private:
V8MessageOrigin m_origin;
double m_timestamp;
- MessageSource m_source;
- MessageLevel m_level;
String16 m_message;
String16 m_url;
unsigned m_lineNumber;
unsigned m_columnNumber;
std::unique_ptr<V8StackTrace> m_stackTrace;
int m_scriptId;
- String16 m_requestIdentifier;
- String16 m_workerId;
int m_contextId;
ConsoleAPIType m_type;
unsigned m_exceptionId;
@@ -114,6 +97,8 @@ public:
void clear();
private:
+ void notifyClear();
+
V8DebuggerImpl* m_debugger;
int m_contextGroupId;
int m_expiredCount;

Powered by Google App Engine
This is Rietveld 408576698