third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h - Issue 2151273003: [DevTools] Move browser logging from Console domain to Log domain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

Issue 2151273003: [DevTools] Move browser logging from Console domain to Log domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@internals-method

Patch Set: protocol improvements Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html ('K') | « third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

index 93fd57a01aa5e2103bb1cd6767efa6011d0d7448..4dbb797d50935f67bfe3fa810e554fbf8fe69606 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

@@ -38,8 +38,8 @@ private:

bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) override;

String16 valueSubtype(v8::Local<v8::Value>) override;

bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;

- void muteWarningsAndDeprecations() override { }

- void unmuteWarningsAndDeprecations() override { }

+ void muteWarningsAndDeprecations(int) override { }

+ void unmuteWarningsAndDeprecations(int) override { }

double currentTimeMS() override { return 0; };

bool isExecutionAllowed() override;