Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2151273003: [DevTools] Move browser logging from Console domain to Log domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@internals-method
Patch Set: protocol improvements Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
index ac15e5134244d41077afd0356b898573cc69ee0a..ab4017532f4bd83714e61a30d5d85921f321e2ae 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
@@ -48,7 +48,6 @@ void V8ConsoleAgentImpl::disable(ErrorString* errorString)
void V8ConsoleAgentImpl::clearMessages(ErrorString* errorString)
{
- m_session->debugger()->ensureConsoleMessageStorage(m_session->contextGroupId())->clear();
}
void V8ConsoleAgentImpl::restore()
@@ -73,30 +72,16 @@ bool V8ConsoleAgentImpl::enabled()
void V8ConsoleAgentImpl::reportAllMessages()
{
V8ConsoleMessageStorage* storage = m_session->debugger()->ensureConsoleMessageStorage(m_session->contextGroupId());
- if (storage->expiredCount()) {
- std::unique_ptr<protocol::Console::ConsoleMessage> expired = protocol::Console::ConsoleMessage::create()
- .setSource(protocol::Console::ConsoleMessage::SourceEnum::Other)
- .setLevel(protocol::Console::ConsoleMessage::LevelEnum::Warning)
- .setText(String16::fromInteger(storage->expiredCount()) + String16("console messages are not shown."))
- .setTimestamp(0)
- .build();
- expired->setType(protocol::Console::ConsoleMessage::TypeEnum::Log);
- expired->setLine(0);
- expired->setColumn(0);
- expired->setUrl("");
- m_frontend.messageAdded(std::move(expired));
- m_frontend.flush();
- }
for (const auto& message : storage->messages()) {
- if (message->origin() == V8MessageOrigin::kExternalConsole || message->origin() == V8MessageOrigin::kConsole)
+ if (message->origin() == V8MessageOrigin::kConsole)
reportMessage(message.get(), false);
}
}
void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generatePreview)
{
- DCHECK(message->origin() == V8MessageOrigin::kExternalConsole || message->origin() == V8MessageOrigin::kConsole);
- message->reportToFrontend(&m_frontend, m_session, generatePreview);
+ DCHECK(message->origin() == V8MessageOrigin::kConsole);
+ message->reportToFrontend(&m_frontend);
m_frontend.flush();
}

Powered by Google App Engine
This is Rietveld 408576698