Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 2151273003: [DevTools] Move browser logging from Console domain to Log domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@internals-method
Patch Set: protocol improvements Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
index 9a33e0692866a804f6ad97f969364a1ec7b92aa2..d7dfc5f7b4d736d278b146c0ac511600d3f27b74 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
@@ -68,6 +68,7 @@ public:
bool isPaused() const { return m_paused; }
void setClientMessageLoop(std::unique_ptr<ClientMessageLoop>);
void reportConsoleMessage(ExecutionContext*, ConsoleMessage*) override;
+ int contextGroupId(ExecutionContext*) override;
// TODO(dgozman): by making this method virtual, we can move many methods to ThreadDebugger and avoid some duplication. Should be careful about performance.
int contextGroupId(LocalFrame*);
@@ -75,7 +76,6 @@ public:
void contextCreated(ScriptState*, LocalFrame*, SecurityOrigin*);
void contextWillBeDestroyed(ScriptState*);
void exceptionThrown(LocalFrame*, const String& errorMessage, std::unique_ptr<SourceLocation>);
- bool addConsoleMessage(LocalFrame*, ConsoleMessage*);
void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;
@@ -85,8 +85,8 @@ private:
// V8DebuggerClient implementation.
void runMessageLoopOnPause(int contextGroupId) override;
void quitMessageLoopOnPause() override;
- void muteWarningsAndDeprecations() override;
- void unmuteWarningsAndDeprecations() override;
+ void muteWarningsAndDeprecations(int contextGroupId) override;
+ void unmuteWarningsAndDeprecations(int contextGroupId) override;
bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) override;
v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) override;
void consoleAPIMessage(int contextGroupId, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) override;
@@ -94,7 +94,6 @@ private:
std::unique_ptr<ClientMessageLoop> m_clientMessageLoop;
std::unique_ptr<InspectorTaskRunner> m_taskRunner;
bool m_paused;
- int m_muteConsoleCount;
static MainThreadDebugger* s_instance;

Powered by Google App Engine
This is Rietveld 408576698