Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2150633002: cc: Pass SurfaceId by const ref in more places (Closed)

Created:
4 years, 5 months ago by Fady Samuel
Modified:
4 years, 5 months ago
Reviewers:
weiliangc, jam
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, James Su, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Pass SurfaceId by const ref in more places SurfaceId is 128-bits and so it cannot fit in a single register. Thus passing it around by const reference is potentially more efficient, and more consistent with how we pass around other non-trivial structs such as gfx::Rect. BUG=none CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/2c5cb07a5bb810d82e021a26d8cba2bb5664420e Cr-Commit-Position: refs/heads/master@{#405267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -64 lines) Patch
M cc/surfaces/surface.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/surfaces/surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_aggregator.h View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M cc/surfaces/surface_factory.h View 1 chunk +7 lines, -6 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M cc/surfaces/surface_hittest.h View 2 chunks +7 lines, -7 lines 0 comments Download
M cc/surfaces/surface_hittest.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M cc/surfaces/surface_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/surface_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Fady Samuel
+weilangc@ for cc +jam@ for content.
4 years, 5 months ago (2016-07-13 17:18:41 UTC) #3
weiliangc
LGTM
4 years, 5 months ago (2016-07-13 18:30:53 UTC) #6
jam
lgtm
4 years, 5 months ago (2016-07-13 19:20:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150633002/1
4 years, 5 months ago (2016-07-13 19:23:12 UTC) #11
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names without "master." prefix is ...
4 years, 5 months ago (2016-07-13 19:34:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 20:19:15 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:22:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c5cb07a5bb810d82e021a26d8cba2bb5664420e
Cr-Commit-Position: refs/heads/master@{#405267}

Powered by Google App Engine
This is Rietveld 408576698