Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3810)

Unified Diff: cc/surfaces/surface_factory.cc

Issue 2150633002: cc: Pass SurfaceId by const ref in more places (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_factory.h ('k') | cc/surfaces/surface_hittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_factory.cc
diff --git a/cc/surfaces/surface_factory.cc b/cc/surfaces/surface_factory.cc
index 03517c4613cfc79e3a3235bda0f653d583b842fd..345171a0f31f76873a83c1c1d01071a38f23ef4e 100644
--- a/cc/surfaces/surface_factory.cc
+++ b/cc/surfaces/surface_factory.cc
@@ -39,14 +39,14 @@ void SurfaceFactory::DestroyAll() {
surface_map_.clear();
}
-void SurfaceFactory::Create(SurfaceId surface_id) {
+void SurfaceFactory::Create(const SurfaceId& surface_id) {
std::unique_ptr<Surface> surface(new Surface(surface_id, this));
manager_->RegisterSurface(surface.get());
DCHECK(!surface_map_.count(surface_id));
surface_map_[surface_id] = std::move(surface);
}
-void SurfaceFactory::Destroy(SurfaceId surface_id) {
+void SurfaceFactory::Destroy(const SurfaceId& surface_id) {
OwningSurfaceMap::iterator it = surface_map_.find(surface_id);
DCHECK(it != surface_map_.end());
DCHECK(it->second->factory().get() == this);
@@ -56,8 +56,8 @@ void SurfaceFactory::Destroy(SurfaceId surface_id) {
manager_->Destroy(std::move(surface));
}
-void SurfaceFactory::SetPreviousFrameSurface(SurfaceId new_id,
- SurfaceId old_id) {
+void SurfaceFactory::SetPreviousFrameSurface(const SurfaceId& new_id,
+ const SurfaceId& old_id) {
OwningSurfaceMap::iterator it = surface_map_.find(new_id);
DCHECK(it != surface_map_.end());
Surface* old_surface = manager_->GetSurfaceForId(old_id);
@@ -66,7 +66,7 @@ void SurfaceFactory::SetPreviousFrameSurface(SurfaceId new_id,
}
}
-void SurfaceFactory::SubmitCompositorFrame(SurfaceId surface_id,
+void SurfaceFactory::SubmitCompositorFrame(const SurfaceId& surface_id,
CompositorFrame frame,
const DrawCallback& callback) {
TRACE_EVENT0("cc", "SurfaceFactory::SubmitCompositorFrame");
@@ -81,7 +81,7 @@ void SurfaceFactory::SubmitCompositorFrame(SurfaceId surface_id,
}
void SurfaceFactory::RequestCopyOfSurface(
- SurfaceId surface_id,
+ const SurfaceId& surface_id,
std::unique_ptr<CopyOutputRequest> copy_request) {
OwningSurfaceMap::iterator it = surface_map_.find(surface_id);
if (it == surface_map_.end()) {
@@ -93,7 +93,7 @@ void SurfaceFactory::RequestCopyOfSurface(
manager_->SurfaceModified(surface_id);
}
-void SurfaceFactory::WillDrawSurface(SurfaceId id,
+void SurfaceFactory::WillDrawSurface(const SurfaceId& id,
const gfx::Rect& damage_rect) {
client_->WillDrawSurface(id, damage_rect);
}
« no previous file with comments | « cc/surfaces/surface_factory.h ('k') | cc/surfaces/surface_hittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698