Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2150633002: cc: Pass SurfaceId by const ref in more places (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 virtual void ProcessGestureEvent(const blink::WebGestureEvent& event, 239 virtual void ProcessGestureEvent(const blink::WebGestureEvent& event,
240 const ui::LatencyInfo& latency) {} 240 const ui::LatencyInfo& latency) {}
241 241
242 // Transform a point that is in the coordinate space of a Surface that is 242 // Transform a point that is in the coordinate space of a Surface that is
243 // embedded within the RenderWidgetHostViewBase's Surface to the 243 // embedded within the RenderWidgetHostViewBase's Surface to the
244 // coordinate space of the embedding Surface. Typically this means that a 244 // coordinate space of the embedding Surface. Typically this means that a
245 // point was received from an out-of-process iframe's RenderWidget and needs 245 // point was received from an out-of-process iframe's RenderWidget and needs
246 // to be translated to viewport coordinates for the root RWHV, in which case 246 // to be translated to viewport coordinates for the root RWHV, in which case
247 // this method is called on the root RWHV with the out-of-process iframe's 247 // this method is called on the root RWHV with the out-of-process iframe's
248 // SurfaceId. 248 // SurfaceId.
249 virtual void TransformPointToLocalCoordSpace(const gfx::Point& point, 249 virtual void TransformPointToLocalCoordSpace(
250 cc::SurfaceId original_surface, 250 const gfx::Point& point,
251 gfx::Point* transformed_point); 251 const cc::SurfaceId& original_surface,
252 gfx::Point* transformed_point);
252 253
253 //---------------------------------------------------------------------------- 254 //----------------------------------------------------------------------------
254 // The following methods are related to IME. 255 // The following methods are related to IME.
255 // TODO(ekaramad): Most of the IME methods should not stay virtual after IME 256 // TODO(ekaramad): Most of the IME methods should not stay virtual after IME
256 // is implemented for OOPIF. After fixing IME, mark the corresponding methods 257 // is implemented for OOPIF. After fixing IME, mark the corresponding methods
257 // non-virtual (https://crbug.com/578168). 258 // non-virtual (https://crbug.com/578168).
258 259
259 // Updates the state of the input method attached to the view. 260 // Updates the state of the input method attached to the view.
260 virtual void TextInputStateChanged(const TextInputState& text_input_state); 261 virtual void TextInputStateChanged(const TextInputState& text_input_state);
261 262
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_; 470 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
470 471
471 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_; 472 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
472 473
473 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase); 474 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
474 }; 475 };
475 476
476 } // namespace content 477 } // namespace content
477 478
478 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 479 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698