Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3128)

Unified Diff: cc/surfaces/surface_factory.h

Issue 2150633002: cc: Pass SurfaceId by const ref in more places (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_aggregator.cc ('k') | cc/surfaces/surface_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_factory.h
diff --git a/cc/surfaces/surface_factory.h b/cc/surfaces/surface_factory.h
index 1acf09fcd1a56522eb03ed0b8b9a72ed4547daea..52f44bbb62b0e915295438df39a3d377f3d1d683 100644
--- a/cc/surfaces/surface_factory.h
+++ b/cc/surfaces/surface_factory.h
@@ -45,25 +45,26 @@ class CC_SURFACES_EXPORT SurfaceFactory
SurfaceFactory(SurfaceManager* manager, SurfaceFactoryClient* client);
~SurfaceFactory();
- void Create(SurfaceId surface_id);
- void Destroy(SurfaceId surface_id);
+ void Create(const SurfaceId& surface_id);
+ void Destroy(const SurfaceId& surface_id);
void DestroyAll();
// Set that the current frame on new_id is to be treated as the successor to
// the current frame on old_id for the purposes of calculating damage.
- void SetPreviousFrameSurface(SurfaceId new_id, SurfaceId old_id);
+ void SetPreviousFrameSurface(const SurfaceId& new_id,
+ const SurfaceId& old_id);
// A frame can only be submitted to a surface created by this factory,
// although the frame may reference surfaces created by other factories.
// The callback is called the first time this frame is used to draw, or if
// the frame is discarded.
- void SubmitCompositorFrame(SurfaceId surface_id,
+ void SubmitCompositorFrame(const SurfaceId& surface_id,
CompositorFrame frame,
const DrawCallback& callback);
- void RequestCopyOfSurface(SurfaceId surface_id,
+ void RequestCopyOfSurface(const SurfaceId& surface_id,
std::unique_ptr<CopyOutputRequest> copy_request);
- void WillDrawSurface(SurfaceId id, const gfx::Rect& damage_rect);
+ void WillDrawSurface(const SurfaceId& id, const gfx::Rect& damage_rect);
SurfaceFactoryClient* client() { return client_; }
« no previous file with comments | « cc/surfaces/surface_aggregator.cc ('k') | cc/surfaces/surface_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698