Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2056)

Unified Diff: cc/surfaces/surface_hittest.h

Issue 2150633002: cc: Pass SurfaceId by const ref in more places (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_factory.cc ('k') | cc/surfaces/surface_hittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_hittest.h
diff --git a/cc/surfaces/surface_hittest.h b/cc/surfaces/surface_hittest.h
index ce45a90f81664c1e2002564c5e18157b7010768e..14f08455ec32e6cde9872bbbb6c614ebbee86cde 100644
--- a/cc/surfaces/surface_hittest.h
+++ b/cc/surfaces/surface_hittest.h
@@ -33,20 +33,20 @@ class CC_SURFACES_EXPORT SurfaceHittest {
// Returns the target surface that falls underneath the provided |point|.
// Also returns the |transform| to convert the |point| to the target surface's
// space.
- SurfaceId GetTargetSurfaceAtPoint(SurfaceId root_surface_id,
+ SurfaceId GetTargetSurfaceAtPoint(const SurfaceId& root_surface_id,
const gfx::Point& point,
gfx::Transform* transform);
// Returns whether the target surface falls inside the provide root surface.
// Returns the |transform| to convert points from the root surface coordinate
// space to the target surface coordinate space.
- bool GetTransformToTargetSurface(SurfaceId root_surface_id,
- SurfaceId target_surface_id,
+ bool GetTransformToTargetSurface(const SurfaceId& root_surface_id,
+ const SurfaceId& target_surface_id,
gfx::Transform* transform);
private:
bool GetTargetSurfaceAtPointInternal(
- SurfaceId surface_id,
+ const SurfaceId& surface_id,
const RenderPassId& render_pass_id,
const gfx::Point& point_in_root_target,
std::set<const RenderPass*>* referenced_passes,
@@ -54,14 +54,14 @@ class CC_SURFACES_EXPORT SurfaceHittest {
gfx::Transform* out_transform);
bool GetTransformToTargetSurfaceInternal(
- SurfaceId root_surface_id,
- SurfaceId target_surface_id,
+ const SurfaceId& root_surface_id,
+ const SurfaceId& target_surface_id,
const RenderPassId& render_pass_id,
std::set<const RenderPass*>* referenced_passes,
gfx::Transform* out_transform);
const RenderPass* GetRenderPassForSurfaceById(
- SurfaceId surface_id,
+ const SurfaceId& surface_id,
const RenderPassId& render_pass_id);
bool PointInQuad(const DrawQuad* quad,
« no previous file with comments | « cc/surfaces/surface_factory.cc ('k') | cc/surfaces/surface_hittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698