Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT.

Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT.

Currently, these handles are always fds. Once ChannelMojo is used for the
browser-loader channel, non-SFI mode can use ChannelMojo instead of
legacy IPC::ChannelPosix.

BUG=604282
Committed: https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396
Cr-Commit-Position: refs/heads/master@{#405369}

[Anand Mistry (off Chromium), 2016-07-13 00:50:08]

amistry@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Anand Mistry (off Chromium), 2016-07-13 00:50:08]

Prep work for using ChannelMojo for the various ppapi channel in non-sfi mode.
For now, everything still uses fds.

[Mark Seaborn, 2016-07-13 19:23:10]

LGTM

https://codereview.chromium.org/2148633002/diff/1/ppapi/nacl_irt/plugin_start...
File ppapi/nacl_irt/plugin_startup.cc (right):

https://codereview.chromium.org/2148633002/diff/1/ppapi/nacl_irt/plugin_start...
ppapi/nacl_irt/plugin_startup.cc:9: #include "base/lazy_instance.h"
Not used?

https://codereview.chromium.org/2148633002/diff/1/ppapi/nacl_irt/plugin_start...
File ppapi/nacl_irt/plugin_startup.h (right):

https://codereview.chromium.org/2148633002/diff/1/ppapi/nacl_irt/plugin_start...
ppapi/nacl_irt/plugin_startup.h:20: // Sets the IPC channels for the browser and
the renderer by the given FD
Update "FD numbers" in comment?

https://codereview.chromium.org/2148633002/diff/1/ppapi/nacl_irt/plugin_start...
ppapi/nacl_irt/plugin_startup.h:24: IPC::ChannelHandle browser_ipc_fd,
"fd" -> "handle"

[Anand Mistry (off Chromium), 2016-07-13 23:49:43]

https://codereview.chromium.org/2148633002/diff/1/ppapi/nacl_irt/plugin_start...
File ppapi/nacl_irt/plugin_startup.cc (right):

https://codereview.chromium.org/2148633002/diff/1/ppapi/nacl_irt/plugin_start...
ppapi/nacl_irt/plugin_startup.cc:9: #include "base/lazy_instance.h"
On 2016/07/13 19:23:10, Mark Seaborn wrote:
> Not used?

Courtesy of the ghost of commits past.

https://codereview.chromium.org/2148633002/diff/1/ppapi/nacl_irt/plugin_start...
File ppapi/nacl_irt/plugin_startup.h (right):

https://codereview.chromium.org/2148633002/diff/1/ppapi/nacl_irt/plugin_start...
ppapi/nacl_irt/plugin_startup.h:20: // Sets the IPC channels for the browser and
the renderer by the given FD
On 2016/07/13 19:23:10, Mark Seaborn wrote:
> Update "FD numbers" in comment?

Done.

https://codereview.chromium.org/2148633002/diff/1/ppapi/nacl_irt/plugin_start...
ppapi/nacl_irt/plugin_startup.h:24: IPC::ChannelHandle browser_ipc_fd,
On 2016/07/13 19:23:10, Mark Seaborn wrote:
> "fd" -> "handle"

Done.

[Anand Mistry (off Chromium), 2016-07-13 23:49:46]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2016-07-13 23:49:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org
Link to the patchset: https://codereview.chromium.org/2148633002/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-07-13 23:50:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 00:44:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 00:44:22]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 00:46:12]

Description was changed from

==========
Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT.

Currently, these handles are always fds. Once ChannelMojo is used for the
browser-loader channel, non-SFI mode can use ChannelMojo instead of
legacy IPC::ChannelPosix.

BUG=604282
==========

to

==========
Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT.

Currently, these handles are always fds. Once ChannelMojo is used for the
browser-loader channel, non-SFI mode can use ChannelMojo instead of
legacy IPC::ChannelPosix.

BUG=604282

Committed: https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396
Cr-Commit-Position: refs/heads/master@{#405369}
==========

[commit-bot: I haz the power, 2016-07-14 00:46:13]

Patchset 2 (id:??) landed as
https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396
Cr-Commit-Position: refs/heads/master@{#405369}