ppapi/nacl_irt/irt_ppapi.cc - Issue 2148633002: Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/nacl_irt/irt_ppapi.cc

Issue 2148633002: Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/nacl_irt/irt_ppapi.cc

diff --git a/ppapi/nacl_irt/irt_ppapi.cc b/ppapi/nacl_irt/irt_ppapi.cc

index 8d2f715b0cbea26bb7de5be3995707a8cf1a4a6f..e2f2dc92b7c882bc3b8d2935ececc434fd0ba440 100644

--- a/ppapi/nacl_irt/irt_ppapi.cc

+++ b/ppapi/nacl_irt/irt_ppapi.cc

@@ -38,8 +38,8 @@ int irt_ppapi_start(const struct PP_StartFunctions* funcs) {

ppapi::PpapiDispatcher ppapi_dispatcher(

ppapi::GetIOThread()->task_runner(), ppapi::GetShutdownEvent(),

- ppapi::GetBrowserIPCFileDescriptor(),

- ppapi::GetRendererIPCFileDescriptor());

+ ppapi::GetBrowserIPCChannelHandle(),

+ ppapi::GetRendererIPCChannelHandle());

plugin_globals.SetPluginProxyDelegate(&ppapi_dispatcher);

loop.Run();

« no previous file with comments | « ppapi/nacl_irt/irt_pnacl_translator_link.cc ('k') | ppapi/nacl_irt/irt_start.cc » ('j') | no next file with comments »