Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: components/nacl/loader/nonsfi/nonsfi_listener.cc

Issue 2148633002: Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/nacl_irt/irt_pnacl_translator_compile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/loader/nonsfi/nonsfi_listener.cc
diff --git a/components/nacl/loader/nonsfi/nonsfi_listener.cc b/components/nacl/loader/nonsfi/nonsfi_listener.cc
index 2ea4d5988cb5588c5f59892783202fabfd062ea6..3ee8aa096384f2961030b0464e7b1fa6866b8a73 100644
--- a/components/nacl/loader/nonsfi/nonsfi_listener.cc
+++ b/components/nacl/loader/nonsfi/nonsfi_listener.cc
@@ -92,10 +92,10 @@ void NonSfiListener::OnStart(const nacl::NaClStartParams& params) {
CHECK_NE(params.trusted_service_channel_handle.socket.fd, -1);
CHECK_NE(params.manifest_service_channel_handle.socket.fd, -1);
- ppapi::SetIPCFileDescriptors(
- params.ppapi_browser_channel_handle.socket.fd,
- params.ppapi_renderer_channel_handle.socket.fd,
- params.manifest_service_channel_handle.socket.fd);
+ ppapi::SetIPCChannelHandles(
+ params.ppapi_browser_channel_handle,
+ params.ppapi_renderer_channel_handle,
+ params.manifest_service_channel_handle);
ppapi::StartUpPlugin();
// TODO(teravest): Do we plan on using this renderer handle for nexe loading
« no previous file with comments | « no previous file | ppapi/nacl_irt/irt_pnacl_translator_compile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698