ppapi/nacl_irt/irt_pnacl_translator_link.cc - Issue 2148633002: Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/nacl_irt/irt_pnacl_translator_link.cc

Issue 2148633002: Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/nacl_irt/irt_pnacl_translator_link.cc

diff --git a/ppapi/nacl_irt/irt_pnacl_translator_link.cc b/ppapi/nacl_irt/irt_pnacl_translator_link.cc

index dc88a7a24949a07d9e77d01824af3b2ee04c6fb1..e2e35410f1996dbaae6dd9da911501956395805c 100644

--- a/ppapi/nacl_irt/irt_pnacl_translator_link.cc

+++ b/ppapi/nacl_irt/irt_pnacl_translator_link.cc

@@ -71,9 +71,7 @@ class TranslatorLinkListener : public IPC::Listener {

void ServeLinkRequest(CallbackFunc func) {

base::MessageLoop loop;

- int fd = ppapi::GetRendererIPCFileDescriptor();

- IPC::ChannelHandle handle("NaCl IPC", base::FileDescriptor(fd, false));

- new TranslatorLinkListener(handle, func);

+ new TranslatorLinkListener(ppapi::GetRendererIPCChannelHandle(), func);

loop.Run();

}

« no previous file with comments | « ppapi/nacl_irt/irt_pnacl_translator_compile.cc ('k') | ppapi/nacl_irt/irt_ppapi.cc » ('j') | no next file with comments »