Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2212)

Unified Diff: ppapi/nacl_irt/ppapi_dispatcher.h

Issue 2148633002: Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/nacl_irt/plugin_startup.cc ('k') | ppapi/nacl_irt/ppapi_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/nacl_irt/ppapi_dispatcher.h
diff --git a/ppapi/nacl_irt/ppapi_dispatcher.h b/ppapi/nacl_irt/ppapi_dispatcher.h
index 4cb3b1138a86ed8f67226744b711537b1b8ea7ee..953db41a45055e996781ebc296e96a4148993a6e 100644
--- a/ppapi/nacl_irt/ppapi_dispatcher.h
+++ b/ppapi/nacl_irt/ppapi_dispatcher.h
@@ -14,6 +14,7 @@
#include "base/files/file.h"
#include "base/memory/ref_counted.h"
#include "base/process/process_handle.h"
+#include "ipc/ipc_channel_handle.h"
#include "ipc/ipc_listener.h"
#include "ipc/ipc_platform_file.h"
#include "ipc/ipc_sender.h"
@@ -50,8 +51,8 @@ class PpapiDispatcher : public proxy::PluginDispatcher::PluginDelegate,
public:
PpapiDispatcher(scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
base::WaitableEvent* shutdown_event,
- int browser_ipc_fd,
- int renderer_ipc_fd);
+ IPC::ChannelHandle browser_ipc_handle,
+ IPC::ChannelHandle renderer_ipc_handle);
// PluginDispatcher::PluginDelegate implementation.
base::SingleThreadTaskRunner* GetIPCTaskRunner() override;
@@ -94,7 +95,7 @@ class PpapiDispatcher : public proxy::PluginDispatcher::PluginDelegate,
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
base::WaitableEvent* shutdown_event_;
- int renderer_ipc_fd_;
+ IPC::ChannelHandle renderer_ipc_handle_;
std::unique_ptr<IPC::SyncChannel> channel_;
};
« no previous file with comments | « ppapi/nacl_irt/plugin_startup.cc ('k') | ppapi/nacl_irt/ppapi_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698