Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2146873002: ios: drop dependency on chromium_tests; move analyze to filter module (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

ios: drop dependency on chromium_tests; move analyze to filter module This will make it easier to move chromium_tests out of build repo. BUG=584079 Committed: https://chromium.googlesource.com/chromium/tools/build/+/efa9f4fecbdbc855e658122ee7367f20423c8892

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -53 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 2 chunks +0 lines, -44 lines 0 comments Download
M scripts/slave/recipe_modules/filter/api.py View 2 chunks +47 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/ios/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 2 chunks +4 lines, -5 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/findit/chromium/test.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-13 12:55:31 UTC) #2
tandrii(chromium)
lgtm
4 years, 5 months ago (2016-07-13 13:04:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146873002/1
4 years, 5 months ago (2016-07-13 13:05:33 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 13:10:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/efa9f4fecbdbc855e658...

Powered by Google App Engine
This is Rietveld 408576698