Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 2146873002: ios: drop dependency on chromium_tests; move analyze to filter module (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/filter/api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_tests/api.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py
index 19653dbe102e572c48e8d05f640995ae81ff6daa..a67bc3f596b7ceeea0b420af87f114967264122e 100644
--- a/scripts/slave/recipe_modules/chromium_tests/api.py
+++ b/scripts/slave/recipe_modules/chromium_tests/api.py
@@ -9,7 +9,6 @@ import json
from recipe_engine.types import freeze
from recipe_engine import recipe_api
-from recipe_engine import util as recipe_util
from . import bot_config_and_test_db as bdb_module
from . import builders
@@ -663,49 +662,6 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
files[i] = path[len(relative_to):]
return files
- def analyze(self, affected_files, test_targets, additional_compile_targets,
- config_file_name, mb_mastername=None, mb_buildername=None,
- additional_names=None):
- """Runs "analyze" step to determine targets affected by the patch.
-
- Returns a tuple of:
- - list of targets that are needed to run tests (see filter recipe module)
- - list of targets that need to be compiled (see filter recipe module)"""
-
- if additional_names is None:
- additional_names = ['chromium']
-
- use_mb = (self.m.chromium.c.project_generator.tool == 'mb')
- build_output_dir = '//out/%s' % self.m.chromium.c.build_config_fs
- self.m.filter.does_patch_require_compile(
- affected_files,
- test_targets=test_targets,
- additional_compile_targets=additional_compile_targets,
- additional_names=additional_names,
- config_file_name=config_file_name,
- use_mb=use_mb,
- mb_mastername=mb_mastername,
- mb_buildername=mb_buildername,
- build_output_dir=build_output_dir,
- cros_board=self.m.chromium.c.TARGET_CROS_BOARD)
-
- compile_targets = self.m.filter.compile_targets[:]
-
- # Emit more detailed output useful for debugging.
- analyze_details = {
- 'test_targets': test_targets,
- 'additional_compile_targets': additional_compile_targets,
- 'self.m.filter.compile_targets': self.m.filter.compile_targets,
- 'self.m.filter.test_targets': self.m.filter.test_targets,
- 'compile_targets': compile_targets,
- }
- with contextlib.closing(recipe_util.StringListIO()) as listio:
- json.dump(analyze_details, listio, indent=2, sort_keys=True)
- step_result = self.m.step.active_result
- step_result.presentation.logs['analyze_details'] = listio.lines
-
- return self.m.filter.test_targets, compile_targets
-
# TODO(phajdan.jr): fix callers and remove chromium_tests.configure_swarming.
def configure_swarming(self, project_name, precommit, mastername=None):
return self.m.chromium_swarming.configure_swarming( # pragma: no cover
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/filter/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698