Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: scripts/slave/recipes/findit/chromium/compile.py

Issue 2146873002: ios: drop dependency on chromium_tests; move analyze to filter module (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « scripts/slave/recipes/chromium_trybot.py ('k') | scripts/slave/recipes/findit/chromium/test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import json 5 import json
6 6
7 from recipe_engine.config import List 7 from recipe_engine.config import List
8 from recipe_engine.config import Single 8 from recipe_engine.config import Single
9 from recipe_engine.recipe_api import Property 9 from recipe_engine.recipe_api import Property
10 10
11 11
12 DEPS = [ 12 DEPS = [
13 'buildbucket', 13 'buildbucket',
14 'chromium', 14 'chromium',
15 'chromium_tests', 15 'chromium_tests',
16 'filter',
16 'findit', 17 'findit',
17 'depot_tools/gclient', 18 'depot_tools/gclient',
18 'recipe_engine/json', 19 'recipe_engine/json',
19 'recipe_engine/path', 20 'recipe_engine/path',
20 'recipe_engine/platform', 21 'recipe_engine/platform',
21 'recipe_engine/properties', 22 'recipe_engine/properties',
22 'recipe_engine/python', 23 'recipe_engine/python',
23 'recipe_engine/raw_io', 24 'recipe_engine/raw_io',
24 'recipe_engine/step', 25 'recipe_engine/step',
25 ] 26 ]
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 bot_config, bot_db) 79 bot_config, bot_db)
79 compile_targets = api.chromium_tests.get_compile_targets( 80 compile_targets = api.chromium_tests.get_compile_targets(
80 bot_config, bot_db, tests_including_triggered) 81 bot_config, bot_db, tests_including_triggered)
81 82
82 # Use dependency "analyze" to filter out those that are not impacted by 83 # Use dependency "analyze" to filter out those that are not impacted by
83 # the given revision. This is to reduce the number of targets to be 84 # the given revision. This is to reduce the number of targets to be
84 # compiled. 85 # compiled.
85 if use_analyze: 86 if use_analyze:
86 changed_files = api.findit.files_changed_by_revision(revision) 87 changed_files = api.findit.files_changed_by_revision(revision)
87 88
88 _, compile_targets = api.chromium_tests.analyze( 89 _, compile_targets = api.filter.analyze(
89 changed_files, 90 changed_files,
90 test_targets=[], 91 test_targets=[],
91 additional_compile_targets=compile_targets, 92 additional_compile_targets=compile_targets,
92 config_file_name='trybot_analyze_config.json', 93 config_file_name='trybot_analyze_config.json',
93 mb_mastername=target_mastername, 94 mb_mastername=target_mastername,
94 mb_buildername=target_buildername, 95 mb_buildername=target_buildername,
95 additional_names=None) 96 additional_names=None)
96 else: 97 else:
97 # Use ninja to filter out none-existing targets. 98 # Use ninja to filter out none-existing targets.
98 compile_targets = api.findit.existing_targets( 99 compile_targets = api.findit.existing_targets(
(...skipping 580 matching lines...) Expand 10 before | Expand all | Expand 10 after
679 'found': ['target_name'], 680 'found': ['target_name'],
680 'not_found': [], 681 'not_found': [],
681 })) + 682 })) +
682 api.override_step_data('test r5.check_targets', 683 api.override_step_data('test r5.check_targets',
683 api.json.output({ 684 api.json.output({
684 'found': ['target_name'], 685 'found': ['target_name'],
685 'not_found': [], 686 'not_found': [],
686 })) + 687 })) +
687 api.override_step_data('test r5.compile', retcode=1) 688 api.override_step_data('test r5.compile', retcode=1)
688 ) 689 )
OLDNEW
« no previous file with comments | « scripts/slave/recipes/chromium_trybot.py ('k') | scripts/slave/recipes/findit/chromium/test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698