scripts/slave/recipes/findit/chromium/compile.py - Issue 2146873002: ios: drop dependency on chromium_tests; move analyze to filter module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/findit/chromium/compile.py

Issue 2146873002: ios: drop dependency on chromium_tests; move analyze to filter module (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/findit/chromium/compile.py

diff --git a/scripts/slave/recipes/findit/chromium/compile.py b/scripts/slave/recipes/findit/chromium/compile.py

index 85db25cc84e3700438228f4ce1c5594c3ee23382..1b76e87a0301df205abb4e48518e6600a210b2c2 100644

--- a/scripts/slave/recipes/findit/chromium/compile.py

+++ b/scripts/slave/recipes/findit/chromium/compile.py

@@ -13,6 +13,7 @@ DEPS = [

'buildbucket',

'chromium',

'chromium_tests',

+ 'filter',

'findit',

'depot_tools/gclient',

'recipe_engine/json',

@@ -85,7 +86,7 @@ def _run_compile_at_revision(api, target_mastername, target_buildername,

if use_analyze:

changed_files = api.findit.files_changed_by_revision(revision)

- _, compile_targets = api.chromium_tests.analyze(

+ _, compile_targets = api.filter.analyze(

changed_files,

test_targets=[],

additional_compile_targets=compile_targets,

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.py ('k') | scripts/slave/recipes/findit/chromium/test.py » ('j') | no next file with comments »